Bug 64554 - Remove the notion of TestExpectationLine.valid, start storing parsing errors in expectations themselves.
Summary: Remove the notion of TestExpectationLine.valid, start storing parsing errors ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dimitri Glazkov (Google)
URL:
Keywords:
Depends on: 64531
Blocks: 64385 64559
  Show dependency treegraph
 
Reported: 2011-07-14 13:01 PDT by Dimitri Glazkov (Google)
Modified: 2011-07-15 08:51 PDT (History)
1 user (show)

See Also:


Attachments
Patch (20.61 KB, patch)
2011-07-14 13:09 PDT, Dimitri Glazkov (Google)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dimitri Glazkov (Google) 2011-07-14 13:01:59 PDT
Remove the notion of TestExpectationLine.valid, start storing parsing errors in expectations themselves.
Comment 1 Dimitri Glazkov (Google) 2011-07-14 13:09:53 PDT
Created attachment 100852 [details]
Patch
Comment 2 Adam Barth 2011-07-14 22:47:43 PDT
Comment on attachment 100852 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=100852&action=review

> Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py:726
> +            modifiers = [o for o in options if o in self.MODIFIERS]

normally we'd use the variable option instead of o
Comment 3 Adam Barth 2011-07-14 22:48:40 PDT
Comment on attachment 100852 [details]
Patch

I mean, I feel like I don't fully understand this change, which makes me hesitant to review it.  However, the direction looks good.
Comment 4 Dimitri Glazkov (Google) 2011-07-15 08:51:43 PDT
Comment on attachment 100852 [details]
Patch

Clearing flags on attachment: 100852

Committed r91071: <http://trac.webkit.org/changeset/91071>
Comment 5 Dimitri Glazkov (Google) 2011-07-15 08:51:48 PDT
All reviewed patches have been landed.  Closing bug.