Bug 64542 – Move TransformState to platform/graphics and give it the option to transform just a FloatQuad

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Chris Marrin]

Move TransformState to platform/graphics and give it the option to transform just a FloatQuad

[Chris Marrin]

Created attachment 100876 [details]
Patch

[Chris Marrin]

Created attachment 100878 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 100878 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=100878&action=review

I think this looks good, but would like to see HitTestingTransformState stay in rendering. Is there a way to share the code but just have a RefCounted subclass?

> Source/WebCore/platform/graphics/transforms/TransformState.cpp:133
> +// HitTestingTransformState methods

I think HitTestingTransformState should either be move back under rendering/, or renamed to RefCountedTransformState or something.

> Source/WebCore/platform/graphics/transforms/TransformState.h:103
> -    bool m_mapQuad;
> +    bool m_mapPoint, m_mapQuad;

Style guidelines recommend having these on separate lines.

[WebKit Review Bot]

Comment on attachment 100878 [details]
Patch

Attachment 100878 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/9064394

New failing tests:
fast/repaint/block-selection-gap-in-composited-layer.html
editing/selection/image-before-linebreak.html
editing/selection/replaced-boundaries-3.html
fast/repaint/japanese-rl-selection-repaint.html

[WebKit Review Bot]

Created attachment 100900 [details]
Archive of layout-test-results from ec2-cr-linux-01

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-01  Port: Chromium  Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick

[Chris Marrin]

Created attachment 101009 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 101009 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=101009&action=review

> Source/WebCore/platform/graphics/transforms/TransformState.cpp:29
> +#include <wtf/PassOwnPtr.h>

Don't need this include.

> Source/WebCore/platform/graphics/transforms/TransformState.h:2
> + * Copyright (C) 2009 Apple Inc.  All rights reserved.

+2011

> Source/WebCore/platform/graphics/transforms/TransformState.h:34
> +#include <wtf/PassRefPtr.h>

Not needed?

> Source/WebCore/platform/graphics/transforms/TransformState.h:36
> +#include <wtf/RefCounted.h>

Not needed?

> Source/WebCore/rendering/HitTestingTransformState.cpp:2
> + * Copyright (C) 2009 Apple Inc.  All rights reserved.

Add 2011 too.

> Source/WebCore/rendering/HitTestingTransformState.h:40
> +// So there's really no need for a ref counted version. So This class should be tossed and replaced

s/tossed/removed :)

[WebKit Review Bot]

Comment on attachment 101009 [details]
Patch

Attachment 101009 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/9094360

New failing tests:
fast/repaint/block-selection-gap-in-composited-layer.html
editing/selection/image-before-linebreak.html
editing/selection/replaced-boundaries-3.html
fast/repaint/japanese-rl-selection-repaint.html

[WebKit Review Bot]

Created attachment 101014 [details]
Archive of layout-test-results from ec2-cr-linux-03

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-03  Port: Chromium  Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick

[Chris Marrin]

Created attachment 101027 [details]
Revised patch to fix win build problem

[Chris Marrin]

Created attachment 101037 [details]
Patch

[Chris Marrin]

Created attachment 101039 [details]
Patch

[Chris Marrin]

Landed in http://trac.webkit.org/changeset/91110

[Simon Fraser (smfr)]

Comment on attachment 101039 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=101039&action=review

> Source/WebCore/platform/graphics/transforms/TransformState.cpp:2
> + * Copyright (C) 2009 Apple Inc.  All rights reserved.

+2011

> Source/WebCore/platform/graphics/transforms/TransformState.h:2
> + * Copyright (C) 2009 Apple Inc.  All rights reserved.

+2011

> Source/WebCore/platform/graphics/transforms/TransformState.h:34
> +#include <wtf/PassRefPtr.h>

Remove.

> Source/WebCore/platform/graphics/transforms/TransformState.h:36
> +#include <wtf/RefCounted.h>

Remove.

> Source/WebCore/platform/graphics/transforms/TransformState.h:103
> +    bool m_mapPoint, m_mapQuad;

Separate lines please.