Bug 64537 - REGRESSION (r90809): Setting a checkbox's checked property, doesn't render as checked until app window loses focus
Summary: REGRESSION (r90809): Setting a checkbox's checked property, doesn't render as...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac (Intel) OS X 10.6
: P1 Normal
Assignee: Kent Tamura
URL:
Keywords: InRadar, Regression
Depends on:
Blocks:
 
Reported: 2011-07-14 10:08 PDT by Joel
Modified: 2011-07-14 21:31 PDT (History)
6 users (show)

See Also:

Attachments
Click a row, to see the issue (1.81 KB, text/html)
2011-07-14 10:08 PDT, Joel 		no flags Details
Patch (4.20 KB, patch)
2011-07-14 19:18 PDT, Kent Tamura 		no flags Details | Formatted Diff | Diff
Patch 2 (4.19 KB, patch)
2011-07-14 19:30 PDT, Kent Tamura 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joel 2011-07-14 10:08:00 PDT 
Created attachment 100822 [details]
Click a row, to see the issue

When you set a checkbox's checked property, webkit nightly isn't rendering a checked view of the icon until you remove focus from the entire application window. It is actually checked though, so it's just a visual bug.

Works everywhere else, chrome, firefox, safari
Comment 1 Alexey Proskuryakov 2011-07-14 15:23:52 PDT 
<rdar://problem/9778592>
Comment 2 Kent Tamura 2011-07-14 19:18:41 PDT 
Created attachment 100915 [details]
Patch
Comment 3 Dominic Cooney 2011-07-14 19:26:51 PDT 
Comment on attachment 100915 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=100915&action=review

> LayoutTests/ChangeLog:3
> +        REGRESSION (r90809): Setting a checkbox's checked property, doesn't render as checked until app window looses focus

loses

> Source/WebCore/ChangeLog:3
> +        REGRESSION (r90809): Setting a checkbox's checked property, doesn't render as checked until app window looses focus

loses
Comment 4 Kent Tamura 2011-07-14 19:30:45 PDT 
Created attachment 100916 [details]
Patch 2

Fix typo
Comment 5 Darin Adler 2011-07-14 20:25:33 PDT 
Comment on attachment 100916 [details]
Patch 2

I don’t understand why it is correct to only call updateCheckedRadioButtons for radio buttons. The work in there does not seem to be radio-button-specific despite the function’s name. If that is correct, then the function should be moved into RadioInputType out of HTMLInputElement.
Comment 6 Kent Tamura 2011-07-14 20:38:35 PDT 
Thank you for reviewing.

(In reply to comment #5)
> (From update of attachment 100916 [details])
> I don’t understand why it is correct to only call updateCheckedRadioButtons for radio buttons. The work in there does not seem to be radio-button-specific despite the function’s name. If that is correct, then the function should be moved into RadioInputType out of HTMLInputElement.

I think updateCheckedRadioButton() is really specific to radio buttons, and we should move it to RadioInputType.
Comment 7 WebKit Review Bot 2011-07-14 21:31:42 PDT 
Comment on attachment 100916 [details]
Patch 2

Clearing flags on attachment: 100916

Committed r91047: <http://trac.webkit.org/changeset/91047>
Comment 8 WebKit Review Bot 2011-07-14 21:31:47 PDT 
All reviewed patches have been landed.  Closing bug.