A dirty flag in Ewk_Tile_Unused_Cache is not referenced anywhere and ewk_tile_unused_cache_dirty function is not called. This is a patch for removing the dirty flag and the function for keeping source code clean.
Created attachment 100794 [details] proposed patch A patch for removing the dirty flag and the function which are not using anymore in ewk_tiled_model.c.
LGTM. This removal was announced in webkit-efl mailing list. https://lists.webkit.org/pipermail/webkit-efl/2011-July/000018.html
Informal r+ from my side too.
Comment on attachment 100794 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=100794&action=review OK to the changes. On another note, the first diff in this patch (i.e. Source/WebKit/efl/ChangeLog) has a messed up chunk range of @@ -1,3 +1,15 @@. It should be @@ -1,3 +1,18 @@. Hence patch(1) fails to apply this patch. Did you edit the diff by hand? > Source/WebKit/efl/ChangeLog:6 > + Reviewed by NOBODY (OOPS!). > + > + [EFL] Remove unused code in ewk_tile_model.c > + https://bugs.webkit.org/show_bug.cgi?id=64521 Nit: We changed our changelog entry format such that a changelog entry should have the bug title and URL then the Reviewed by line.
Created attachment 101963 [details] updated patch I am sorry for inconvenience. I updated the patch.
Created attachment 101965 [details] Changed the patch by following the patch rule. Update the patch again to make obsolete the previous patch and change the flags
(In reply to comment #6) > Created an attachment (id=101965) [details] > Changed the patch by following the patch rule. > > Update the patch again to make obsolete the previous patch and change the flags The patch is still malformed and hence cannot be landed by the commit-queue. How are you generating these patches?
Comment on attachment 101965 [details] Changed the patch by following the patch rule. View in context: https://bugs.webkit.org/attachment.cgi?id=101965&action=review > Source/WebKit/efl/ChangeLog:1 > +2011-07-25 jungjik.lee <jungjik.lee@samsung.com> You used your username for your name.
Created attachment 101966 [details] updated patch Sorry for inconvenience. I would not do such a mistake again.
Comment on attachment 101966 [details] updated patch Clearing flags on attachment: 101966 Committed r91741: <http://trac.webkit.org/changeset/91741>
All reviewed patches have been landed. Closing bug.