Bug 64521 - [EFL] Remove unused codes in ewk_tiled_model.c
Summary: [EFL] Remove unused codes in ewk_tiled_model.c
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-14 03:14 PDT by JungJik Lee
Modified: 2011-07-25 22:12 PDT (History)
6 users (show)

See Also:


Attachments
proposed patch (2.93 KB, patch)
2011-07-14 03:34 PDT, JungJik Lee
dbates: review+
dbates: commit-queue-
Details | Formatted Diff | Diff
updated patch (2.93 KB, patch)
2011-07-25 20:09 PDT, JungJik Lee
no flags Details | Formatted Diff | Diff
Changed the patch by following the patch rule. (2.93 KB, patch)
2011-07-25 20:20 PDT, JungJik Lee
no flags Details | Formatted Diff | Diff
updated patch (2.93 KB, patch)
2011-07-25 21:07 PDT, JungJik Lee
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description JungJik Lee 2011-07-14 03:14:51 PDT
A dirty flag in Ewk_Tile_Unused_Cache is not referenced anywhere and ewk_tile_unused_cache_dirty function is not called.
This is a patch for removing the dirty flag and the function for keeping source code clean.
Comment 1 JungJik Lee 2011-07-14 03:34:29 PDT
Created attachment 100794 [details]
proposed patch

A patch for removing the dirty flag and the function which are not using anymore in ewk_tiled_model.c.
Comment 2 Gyuyoung Kim 2011-07-14 03:40:13 PDT
LGTM. This removal was announced in webkit-efl mailing list.
https://lists.webkit.org/pipermail/webkit-efl/2011-July/000018.html
Comment 3 Raphael Kubo da Costa (:rakuco) 2011-07-14 06:43:47 PDT
Informal r+ from my side too.
Comment 4 Daniel Bates 2011-07-25 16:42:46 PDT
Comment on attachment 100794 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=100794&action=review

OK to the changes. On another note, the first diff in this patch (i.e. Source/WebKit/efl/ChangeLog) has a messed up chunk range of @@ -1,3 +1,15 @@. It should be @@ -1,3 +1,18 @@. Hence patch(1) fails to apply this patch. Did you edit the diff by hand?

> Source/WebKit/efl/ChangeLog:6
> +        Reviewed by NOBODY (OOPS!).
> +
> +        [EFL] Remove unused code in ewk_tile_model.c
> +        https://bugs.webkit.org/show_bug.cgi?id=64521

Nit: We changed our changelog entry format such that a changelog entry should have the bug title and URL then the Reviewed by line.
Comment 5 JungJik Lee 2011-07-25 20:09:29 PDT
Created attachment 101963 [details]
updated patch

I am sorry for inconvenience. I updated the patch.
Comment 6 JungJik Lee 2011-07-25 20:20:01 PDT
Created attachment 101965 [details]
Changed the patch by following the patch rule.

Update the patch again to make obsolete the previous patch and change the flags
Comment 7 Daniel Bates 2011-07-25 20:27:37 PDT
(In reply to comment #6)
> Created an attachment (id=101965) [details]
> Changed the patch by following the patch rule.
> 
> Update the patch again to make obsolete the previous patch and change the flags

The patch is still malformed and hence cannot be landed by the commit-queue. How are you generating these patches?
Comment 8 Daniel Bates 2011-07-25 20:31:45 PDT
Comment on attachment 101965 [details]
Changed the patch by following the patch rule.

View in context: https://bugs.webkit.org/attachment.cgi?id=101965&action=review

> Source/WebKit/efl/ChangeLog:1
> +2011-07-25  jungjik.lee  <jungjik.lee@samsung.com>

You used your username for your name.
Comment 9 JungJik Lee 2011-07-25 21:07:33 PDT
Created attachment 101966 [details]
updated patch

Sorry for inconvenience. I would not do such a mistake again.
Comment 10 WebKit Review Bot 2011-07-25 22:12:00 PDT
Comment on attachment 101966 [details]
updated patch

Clearing flags on attachment: 101966

Committed r91741: <http://trac.webkit.org/changeset/91741>
Comment 11 WebKit Review Bot 2011-07-25 22:12:05 PDT
All reviewed patches have been landed.  Closing bug.