Bug 64518 - removes #if ENABLE(DRAG_SUPPORT) check
Summary: removes #if ENABLE(DRAG_SUPPORT) check
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2011-07-14 01:47 PDT by arno.
Modified: 2011-07-25 11:08 PDT (History)
3 users (show)

See Also:


Attachments
removes last ENABLE(DRAG_SUPPORT) gtk check (1.39 KB, patch)
2011-07-14 01:51 PDT, arno.
mrobinson: review-
Details | Formatted Diff | Diff
patch v1.1 (1.57 KB, patch)
2011-07-25 02:00 PDT, arno.
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description arno. 2011-07-14 01:47:28 PDT
Hi,
Source/WebCore/platform/gtk/ClipboardGtk.h
has a 
#if ENABLE(DRAG_SUPPORT)
check.
It's the only place in gtk port where there is this check. In all other places, DRAG_SUPPORT is supposed to be enabled. So, if I understand correctly, it makes little sense to keep it.
Comment 1 arno. 2011-07-14 01:51:56 PDT
Created attachment 100788 [details]
removes last ENABLE(DRAG_SUPPORT) gtk check
Comment 2 Martin Robinson 2011-07-24 18:12:52 PDT
Comment on attachment 100788 [details]
removes last ENABLE(DRAG_SUPPORT) gtk check

View in context: https://bugs.webkit.org/attachment.cgi?id=100788&action=review

This seems fine. It's still used in other places throughout WebCore, but otherwise, only Mac uses it in the platform layer. Please fix the ChangeLog, then we can use the commit-queue to commit this.

> Source/WebCore/ChangeLog:8
> +        No new tests. (OOPS!)

You should remove this line.
Comment 3 arno. 2011-07-25 02:00:22 PDT
Created attachment 101855 [details]
patch v1.1
Comment 4 WebKit Review Bot 2011-07-25 11:08:49 PDT
Comment on attachment 101855 [details]
patch v1.1

Clearing flags on attachment: 101855

Committed r91681: <http://trac.webkit.org/changeset/91681>
Comment 5 WebKit Review Bot 2011-07-25 11:08:53 PDT
All reviewed patches have been landed.  Closing bug.