Bug 64515 - [EFL] Add OwnPtr specialization for Ecore_Pipe.
Summary: [EFL] Add OwnPtr specialization for Ecore_Pipe.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryuan Choi
URL:
Keywords:
Depends on:
Blocks: 64337
  Show dependency tree / graph
 
Reported: 2011-07-14 00:18 PDT by Ryuan Choi
Modified: 2011-07-14 11:03 PDT (History)
4 users (show)

See Also:

Attachments
Patch (1.94 KB, patch)
2011-07-14 00:25 PDT, Ryuan Choi 		no flags Details | Formatted Diff | Diff
Patch (2.01 KB, patch)
2011-07-14 01:07 PDT, Ryuan Choi 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryuan Choi 2011-07-14 00:18:15 PDT 
It's needed for Bug 64337.
Comment 1 Ryuan Choi 2011-07-14 00:25:35 PDT 
Created attachment 100781 [details]
Patch
Comment 2 Ryuan Choi 2011-07-14 00:28:31 PDT 
The style bot will complain struct name, but it's false positive.
Comment 3 WebKit Review Bot 2011-07-14 00:28:33 PDT 
Attachment 100781 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1

Source/JavaScriptCore/wtf/OwnPtrCommon.h:55:  Ecore_Pipe is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Gyuyoung Kim 2011-07-14 00:56:18 PDT 
Comment on attachment 100781 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=100781&action=review

LGTM except for changelog.

> Source/JavaScriptCore/ChangeLog:5
> +

Though this patch is clear, do you need to add simple description for this patch ?
Comment 5 Ryuan Choi 2011-07-14 01:07:46 PDT 
Created attachment 100785 [details]
Patch
Comment 6 Ryuan Choi 2011-07-14 01:08:14 PDT 
(In reply to comment #4)
> (From update of attachment 100781 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=100781&action=review
> 
> LGTM except for changelog.
> 
> > Source/JavaScriptCore/ChangeLog:5
> > +
> 
> Though this patch is clear, do you need to add simple description for this patch ?

I update changelog.
Comment 7 WebKit Review Bot 2011-07-14 01:09:16 PDT 
Attachment 100785 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1

Source/JavaScriptCore/wtf/OwnPtrCommon.h:55:  Ecore_Pipe is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 8 Raphael Kubo da Costa (:rakuco) 2011-07-14 06:42:35 PDT 
LGTM, we just need to find a willing reviewer now.
Comment 9 Xan Lopez 2011-07-14 07:34:28 PDT 
Comment on attachment 100785 [details]
Patch

Looks good. You should figure out a way of teaching the style scripts to ignore your types.
Comment 10 WebKit Review Bot 2011-07-14 11:02:59 PDT 
Comment on attachment 100785 [details]
Patch

Clearing flags on attachment: 100785

Committed r91018: <http://trac.webkit.org/changeset/91018>
Comment 11 WebKit Review Bot 2011-07-14 11:03:06 PDT 
All reviewed patches have been landed.  Closing bug.