Bug 64475 - Move forwardEvent from RenderTextControl to HTMLTextFormControlElement
: Move forwardEvent from RenderTextControl to HTMLTextFormControlElement
Status: RESOLVED FIXED
Product: WebKit
Classification: Unclassified
Component: Forms
: 528+ (Nightly build)
: Unspecified Unspecified
: P2 Normal
Assigned To: Ryosuke Niwa
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-07-13 11:38 PDT by Ryosuke Niwa
Modified: 2011-07-14 00:49 PDT (History)
6 users (show)

See Also:


Attachments
cleanup (10.71 KB, patch)
2011-07-13 11:46 PDT, Ryosuke Niwa
no flags Details | Formatted Diff | Diff
Moved timer-related functions and variables to SearchInputType (20.52 KB, patch)
2011-07-14 00:45 PDT, Ryosuke Niwa
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2011-07-13 11:38:17 PDT
Render objects shouldn't be forwarding events around.  Now that RenderTextControl no longer owns the shadow DOM, forwardEvent should be a member function of HTMLTextFormControlElement, not of RenderTextControl.
Comment 1 Ryosuke Niwa 2011-07-13 11:46:29 PDT
Created attachment 100697 [details]
cleanup
Comment 2 Kent Tamura 2011-07-13 17:42:53 PDT
Comment on attachment 100697 [details]
cleanup

View in context: https://bugs.webkit.org/attachment.cgi?id=100697&action=review

> Source/WebCore/html/HTMLTextFormControlElement.h:42
>  public:
>      enum NeedsToCheckDirtyFlag {CheckDirtyFlag, IgnoreDirtyFlag};
>  
>      virtual ~HTMLTextFormControlElement();
> +    
> +    void forwardEvent(Event*);

protected: is enough.
Comment 3 Dimitri Glazkov (Google) 2011-07-13 19:06:42 PDT
Awesome patch! It would be great to get rid of event forwarding altogether. And this is a great first step.
Comment 4 Ryosuke Niwa 2011-07-13 22:49:51 PDT
(In reply to comment #2)
> (From update of attachment 100697 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=100697&action=review
> 
> > Source/WebCore/html/HTMLTextFormControlElement.h:42
> >  public:
> >      enum NeedsToCheckDirtyFlag {CheckDirtyFlag, IgnoreDirtyFlag};
> >  
> >      virtual ~HTMLTextFormControlElement();
> > +    
> > +    void forwardEvent(Event*);
> 
> protected: is enough.

This turned out to be not the case because TextFieldInputType::forwardEvent calls it :(
Comment 5 Kent Tamura 2011-07-13 22:54:11 PDT
(In reply to comment #4)
> > protected: is enough.
> 
> This turned out to be not the case because TextFieldInputType::forwardEvent calls it :(

Oh, I see.
Comment 6 Ryosuke Niwa 2011-07-14 00:08:48 PDT
Committed r90983: <http://trac.webkit.org/changeset/90983>
Comment 7 Ryosuke Niwa 2011-07-14 00:45:19 PDT
Created attachment 100783 [details]
Moved timer-related functions and variables to SearchInputType
Comment 8 Ryosuke Niwa 2011-07-14 00:49:33 PDT
Comment on attachment 100783 [details]
Moved timer-related functions and variables to SearchInputType

wrong bug.