Bug 64475 - Move forwardEvent from RenderTextControl to HTMLTextFormControlElement
: Move forwardEvent from RenderTextControl to HTMLTextFormControlElement
Status: RESOLVED FIXED
: WebKit
Forms
: 528+ (Nightly build)
: Unspecified Unspecified
: P2 Normal
Assigned To:
:
:
:
:
  Show dependency treegraph
 
Reported: 2011-07-13 11:38 PST by
Modified: 2011-07-14 00:49 PST (History)


Attachments
cleanup (10.71 KB, patch)
2011-07-13 11:46 PST, Ryosuke Niwa
no flags Review Patch | Details | Formatted Diff | Diff
Moved timer-related functions and variables to SearchInputType (20.52 KB, patch)
2011-07-14 00:45 PST, Ryosuke Niwa
no flags Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2011-07-13 11:38:17 PST
Render objects shouldn't be forwarding events around.  Now that RenderTextControl no longer owns the shadow DOM, forwardEvent should be a member function of HTMLTextFormControlElement, not of RenderTextControl.
------- Comment #1 From 2011-07-13 11:46:29 PST -------
Created an attachment (id=100697) [details]
cleanup
------- Comment #2 From 2011-07-13 17:42:53 PST -------
(From update of attachment 100697 [details])
View in context: https://bugs.webkit.org/attachment.cgi?id=100697&action=review

> Source/WebCore/html/HTMLTextFormControlElement.h:42
>  public:
>      enum NeedsToCheckDirtyFlag {CheckDirtyFlag, IgnoreDirtyFlag};
>  
>      virtual ~HTMLTextFormControlElement();
> +    
> +    void forwardEvent(Event*);

protected: is enough.
------- Comment #3 From 2011-07-13 19:06:42 PST -------
Awesome patch! It would be great to get rid of event forwarding altogether. And this is a great first step.
------- Comment #4 From 2011-07-13 22:49:51 PST -------
(In reply to comment #2)
> (From update of attachment 100697 [details] [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=100697&action=review
> 
> > Source/WebCore/html/HTMLTextFormControlElement.h:42
> >  public:
> >      enum NeedsToCheckDirtyFlag {CheckDirtyFlag, IgnoreDirtyFlag};
> >  
> >      virtual ~HTMLTextFormControlElement();
> > +    
> > +    void forwardEvent(Event*);
> 
> protected: is enough.

This turned out to be not the case because TextFieldInputType::forwardEvent calls it :(
------- Comment #5 From 2011-07-13 22:54:11 PST -------
(In reply to comment #4)
> > protected: is enough.
> 
> This turned out to be not the case because TextFieldInputType::forwardEvent calls it :(

Oh, I see.
------- Comment #6 From 2011-07-14 00:08:48 PST -------
Committed r90983: <http://trac.webkit.org/changeset/90983>
------- Comment #7 From 2011-07-14 00:45:19 PST -------
Created an attachment (id=100783) [details]
Moved timer-related functions and variables to SearchInputType
------- Comment #8 From 2011-07-14 00:49:33 PST -------
(From update of attachment 100783 [details])
wrong bug.