Bug 64475 – Move forwardEvent from RenderTextControl to HTMLTextFormControlElement

• Status: RESOLVED
• Resolution: FIXED
• Component: Forms

[Ryosuke Niwa]

Render objects shouldn't be forwarding events around.  Now that RenderTextControl no longer owns the shadow DOM, forwardEvent should be a member function of HTMLTextFormControlElement, not of RenderTextControl.

[Ryosuke Niwa]

Created attachment 100697 [details]
cleanup

[Kent Tamura]

Comment on attachment 100697 [details]
cleanup

View in context: https://bugs.webkit.org/attachment.cgi?id=100697&action=review

> Source/WebCore/html/HTMLTextFormControlElement.h:42
>  public:
>      enum NeedsToCheckDirtyFlag {CheckDirtyFlag, IgnoreDirtyFlag};
>  
>      virtual ~HTMLTextFormControlElement();
> +    
> +    void forwardEvent(Event*);

protected: is enough.

[Dimitri Glazkov (Google)]

Awesome patch! It would be great to get rid of event forwarding altogether. And this is a great first step.

[Ryosuke Niwa]

(In reply to comment #2)
> (From update of attachment 100697 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=100697&action=review
> 
> > Source/WebCore/html/HTMLTextFormControlElement.h:42
> >  public:
> >      enum NeedsToCheckDirtyFlag {CheckDirtyFlag, IgnoreDirtyFlag};
> >  
> >      virtual ~HTMLTextFormControlElement();
> > +    
> > +    void forwardEvent(Event*);
> 
> protected: is enough.

This turned out to be not the case because TextFieldInputType::forwardEvent calls it :(

[Kent Tamura]

(In reply to comment #4)
> > protected: is enough.
> 
> This turned out to be not the case because TextFieldInputType::forwardEvent calls it :(

Oh, I see.

[Ryosuke Niwa]

Committed r90983: <http://trac.webkit.org/changeset/90983>

[Ryosuke Niwa]

Created attachment 100783 [details]
Moved timer-related functions and variables to SearchInputType

[Ryosuke Niwa]

Comment on attachment 100783 [details]
Moved timer-related functions and variables to SearchInputType

wrong bug.