Bug 64462 - Introduce TestExpectationSerializer.list_to_string.
Summary: Introduce TestExpectationSerializer.list_to_string.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dimitri Glazkov (Google)
URL:
Keywords:
Depends on:
Blocks: 64385
  Show dependency tree / graph
 
Reported: 2011-07-13 10:21 PDT by Dimitri Glazkov (Google)
Modified: 2011-07-13 12:40 PDT (History)
1 user (show)

See Also:

Attachments
Patch (4.07 KB, patch)
2011-07-13 10:22 PDT, Dimitri Glazkov (Google) 		no flags Details | Formatted Diff | Diff
Better? (13.26 KB, patch)
2011-07-13 10:45 PDT, Dimitri Glazkov (Google) 		no flags Details | Formatted Diff | Diff
Better? (4.14 KB, patch)
2011-07-13 10:46 PDT, Dimitri Glazkov (Google) 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dimitri Glazkov (Google) 2011-07-13 10:21:48 PDT 
Introduce TestExpectationSerializer.list_to_string.
Comment 1 Dimitri Glazkov (Google) 2011-07-13 10:22:57 PDT 
Created attachment 100682 [details]
Patch
Comment 2 Adam Barth 2011-07-13 10:24:20 PDT 
Comment on attachment 100682 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=100682&action=review

> Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py:514
> +        return TestExpectationSerializer.list_to_string([expectation for expectation in self._expectations if not (expectation.valid and expectation.name in tests and "rebaseline" in expectation.modifiers)])

OMG!  Can we break out a helper function here somewhere?
Comment 3 Dimitri Glazkov (Google) 2011-07-13 10:31:17 PDT 
(In reply to comment #2)
> (From update of attachment 100682 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=100682&action=review
> 
> > Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py:514
> > +        return TestExpectationSerializer.list_to_string([expectation for expectation in self._expectations if not (expectation.valid and expectation.name in tests and "rebaseline" in expectation.modifiers)])
> 
> OMG!  Can we break out a helper function here somewhere?

Lemme try.
Comment 4 Dimitri Glazkov (Google) 2011-07-13 10:45:24 PDT 
Created attachment 100683 [details]
Better?
Comment 5 Dimitri Glazkov (Google) 2011-07-13 10:46:29 PDT 
Created attachment 100684 [details]
Better?
Comment 6 Adam Barth 2011-07-13 10:52:36 PDT 
Comment on attachment 100684 [details]
Better?

Thanks.  Much more understandable!
Comment 7 Dimitri Glazkov (Google) 2011-07-13 12:40:15 PDT 
Comment on attachment 100684 [details]
Better?

Clearing flags on attachment: 100684

Committed r90942: <http://trac.webkit.org/changeset/90942>
Comment 8 Dimitri Glazkov (Google) 2011-07-13 12:40:19 PDT 
All reviewed patches have been landed.  Closing bug.