RESOLVED FIXED 64451
[Qt] Make ownerWidget into a free functions 
https://bugs.webkit.org/show_bug.cgi?id=64451
Summary [Qt] Make ownerWidget into a free functions
Kenneth Rohde Christiansen
Reported 2011-07-13 07:13:14 PDT
Created attachment 100671 [details] Patch SSIA
Attachments
Patch (9.12 KB, patch)
2011-07-13 07:13 PDT, Kenneth Rohde Christiansen 		kling: review+
kling: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2011-07-13 07:15:28 PDT
Comment on attachment 100671 [details] Patch r=me, but missing bug URL in ChangeLog brah!
WebKit Review Bot
Comment 2 2011-07-13 07:17:38 PDT
Attachment 100671 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1 Source/WebKit2/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Source/WebKit2/UIProcess/API/qt/qdesktopwebview.cpp:26: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 2 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Benjamin Poulain
Comment 3 2011-07-13 08:11:16 PDT
Don't waste your time with that. Don't forget Qt 5 is the next step, we won't need that function soon.
Note You need to log in before you can comment on or make changes to this bug.