Bug 64451 - [Qt] Make ownerWidget into a free functions
Summary: [Qt] Make ownerWidget into a free functions
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2011-07-13 07:13 PDT by Kenneth Rohde Christiansen
Modified: 2011-07-13 08:11 PDT (History)
3 users (show)

See Also:

Patch (9.12 KB, patch)
2011-07-13 07:13 PDT, Kenneth Rohde Christiansen
kling: review+
kling: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kenneth Rohde Christiansen 2011-07-13 07:13:14 PDT
Created attachment 100671 [details]

Comment 1 Andreas Kling 2011-07-13 07:15:28 PDT
Comment on attachment 100671 [details]

r=me, but missing bug URL in ChangeLog brah!
Comment 2 WebKit Review Bot 2011-07-13 07:17:38 PDT
Attachment 100671 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1

Source/WebKit2/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Source/WebKit2/UIProcess/API/qt/qdesktopwebview.cpp:26:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 2 in 3 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Benjamin Poulain 2011-07-13 08:11:16 PDT
Don't waste your time with that. Don't forget Qt 5 is the next step, we won't need that function soon.