Bug 64444 – [CSSRegions]Parse -webkit-region-overflow property

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Mihnea Ovidenie]

Parse region-overflow property, as described in http://www.w3.org/TR/css3-regions/#the-region-overflow-property

[Mihnea Ovidenie]

Created attachment 100672 [details]
Patch

[WebKit Review Bot]

Attachment 100672 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast..." exit_code: 1

Source/WebCore/css/CSSPrimitiveValueMappings.h:1347:  A case label should not be indented, but line up with its switch statement.  [whitespace/indent] [4]
Source/WebCore/css/CSSPrimitiveValueMappings.h:1359:  A case label should not be indented, but line up with its switch statement.  [whitespace/indent] [4]
Total errors found: 2 in 16 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Mihnea Ovidenie]

A large part of the switch constructions in CSSPrimitiveValueMappings.h are suffering from the same style issue. I can volunteer to remove the style warning in this file, if someone thinks it is worth the effort.

[Dave Hyatt]

Comment on attachment 100672 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=100672&action=review

Minor nits with the enum.

> Source/WebCore/css/CSSPrimitiveValueMappings.h:1358
> +    switch (m_value.ident) {

Fix the style issues with the switch statements here.

> Source/WebCore/rendering/style/RenderStyleConstants.h:441
> +#if ENABLE(CSS_REGIONS)
> +enum ERegionOverflow { ROAuto, ROBreak };
> +#endif

This is really an obsolete style that we haven't gotten around to eliminating. Just do this instead:

enum RegionOverflow { AutoRegionOverflow, BreakRegionOverflow };

[Mihnea Ovidenie]

Created attachment 100791 [details]
Patch 2

Second version of patch.

[Dave Hyatt]

Comment on attachment 100791 [details]
Patch 2

r=me

[WebKit Review Bot]

Comment on attachment 100791 [details]
Patch 2

Rejecting attachment 100791 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=ec2-cq-02', '--port..." exit_code: 2

Last 500 characters of output:
1506a4d838b3461cb2fe5a17936512946a2893b0
r91211 = ba255a67dd58a2d5d6f8ff894a4cae1dec952aed
Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc
First, rewinding head to replay your work on top of it...
Fast-forwarded master to refs/remotes/origin/master.
Updating chromium port dependencies using gclient...

________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium'
Updating webkit projects from gyp files...

Full output: http://queues.webkit.org/results/9112451

[Mihnea Ovidenie]

Created attachment 101322 [details]
Patch 3

Same patch with Changelog changes. Somehow i failed to include these changes in the previous patch. My bad.

[Dave Hyatt]

Comment on attachment 101322 [details]
Patch 3

r=me

[WebKit Review Bot]

Comment on attachment 101322 [details]
Patch 3

Clearing flags on attachment: 101322

Committed r91286: <http://trac.webkit.org/changeset/91286>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.