new-run-webkit-tests has incorrect fallback for win port
Created attachment 100650 [details] Patch
Comment on attachment 100650 [details] Patch This is really a wip patch.
Attachment 100650 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/Scripts/webkitpy..." exit_code: 1 Tools/Scripts/webkitpy/layout_tests/port/base.py:560: at least two spaces before inline comment [pep8/E261] [5] Total errors found: 1 in 18 files If any of these errors are false positives, please file a bug against check-webkit-style.
*** Bug 64469 has been marked as a duplicate of this bug. ***
Comment on attachment 100650 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=100650&action=review > Tools/Scripts/webkitpy/layout_tests/port/win.py:58 > + if not hasattr(sys, 'getwindowsversion'): Cygwin's Python doesn't have sys.getwindowsversion(), so this won't work as-is for Apple's Windows port.
I guess we'll have to make our own wrapper around GetVersionEx then?
We should be able to build such with ctypes: http://docs.python.org/library/ctypes.html But I think that may be beyond my ability without having a windows machine easily accessible.
(In reply to comment #6) > I guess we'll have to make our own wrapper around GetVersionEx then? Or we could run `cmd /c ver`, like ORWT does.
I think this just ended up a duplicate of bug 64486
Much of the factory stuff and SUPPORTED_OS_VERSIONS code has been replaced by the new TestConfiguration stuff. I think we can close this as fixed or duplicate.