Bug 64431 - Some ApplicationCache Origin Cleanup
Summary: Some ApplicationCache Origin Cleanup
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-12 21:48 PDT by Joseph Pecoraro
Modified: 2011-07-13 14:42 PDT (History)
2 users (show)

See Also:

Attachments
[PATCH] Some Cleanup (5.44 KB, patch)
2011-07-12 22:02 PDT, Joseph Pecoraro 		ap: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2011-07-12 21:48:49 PDT 
- m_loadedSize is inaccurate and can just be replaced by ApplicationCache::estimatedSizeInStorage
- m_availableSpaceInQuota can get out dated, and should just be recalculated at the start of downloads
Comment 1 Joseph Pecoraro 2011-07-12 22:02:12 PDT 
Created attachment 100628 [details]
[PATCH] Some Cleanup

Don't let the patch confuse you. I just changed the "if quota < m_loadedSize"
check to use estimatedSizeInStorage and moved it down a few lines below
the addResource call.
Comment 2 Joseph Pecoraro 2011-07-13 14:42:34 PDT 
Landed in r90947 <http://trac.webkit.org/changeset/90947>.