Implement paintMediaFullscreenButton and Emit fullscreen signal in addition to implement functions for full screen in ChromeClientEfl.
Created attachment 100615 [details]
This patch doesn't add normal screen button yet on full screen mode. The normal screen button will be added after finishing implementation of full screen mode.
Looks mostly OK to me, with a few nitpicks below:
> + Implement paintMediaFullscreenButton and Emit fullscreen signal.
Emit -> emit
> + Implement functions for full screen in ChrmeClientEfl in order to display a full screen button on media control UI.
ChrmeClientEfl -> ChromeClientEfl
> + Copyright (C) 2011 Samsung Electronics
Are all these copyrights really needed for such a small file?
Created attachment 100746 [details]
I fixed wrong descriptions.
>> Are all these copyrights really needed for such a small file?
Other .edc files have same copyrights. So, I think this file need to have same copyright as well.
I Am Not A Lawyer (TM), but in theory the other files should have all those copyrights because they derive from the original work done by INdT, right? This new EDC looks like some new work whose copyright should belong only to Samsung.
As for the rest, r+ from my side (dunno if you need to consult your legal side or if it can be committed as-is).
Created attachment 101123 [details]
ok, I think previous copyright is unneeded. If this patch is based on other patch which has previous copyright, I think we should mention previous copyright. But, this .edc file refer to Lucas comment. So, I leave profusion copyright.
Could you anyone review this patch?
Informal r+ from my side.
Comment on attachment 101123 [details]
Clearing flags on attachment: 101123
Committed r92189: <http://trac.webkit.org/changeset/92189>
All reviewed patches have been landed. Closing bug.