Bug 64422 - Adjust garden-o-matic layout to use fewer lines
Summary: Adjust garden-o-matic layout to use fewer lines
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks: 64188
  Show dependency treegraph
 
Reported: 2011-07-12 19:16 PDT by Adam Barth
Modified: 2011-07-12 19:41 PDT (History)
3 users (show)

See Also:


Attachments
Patch (4.36 KB, patch)
2011-07-12 19:18 PDT, Adam Barth
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2011-07-12 19:16:45 PDT
Adjust garden-o-matic layout to use fewer lines
Comment 1 Adam Barth 2011-07-12 19:18:23 PDT
Created attachment 100607 [details]
Patch
Comment 2 Adam Barth 2011-07-12 19:22:58 PDT
+ojan

Thanks for reviewing these patches!
Comment 3 Ojan Vafai 2011-07-12 19:24:56 PDT
Comment on attachment 100607 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=100607&action=review

> Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js:35
> +          '<div class="when">' +

Do you still need the "when" classname? It makes less sense now that it includes failure count.
Comment 4 Adam Barth 2011-07-12 19:31:34 PDT
(In reply to comment #3)
> (From update of attachment 100607 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=100607&action=review
> 
> > Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js:35
> > +          '<div class="when">' +
> 
> Do you still need the "when" classname? It makes less sense now that it includes failure count.

Yeah, I'm not sure we do.  This stuff is mostly cargo-cult from dglazkov's mocks.
Comment 5 Adam Barth 2011-07-12 19:39:57 PDT
I'm going to leave it for now.  It's not hurting anyone.
Comment 6 Adam Barth 2011-07-12 19:41:24 PDT
Comment on attachment 100607 [details]
Patch

Clearing flags on attachment: 100607

Committed r90881: <http://trac.webkit.org/changeset/90881>
Comment 7 Adam Barth 2011-07-12 19:41:28 PDT
All reviewed patches have been landed.  Closing bug.