RESOLVED FIXED 64416
Don't reuse the last InsertTextCommand 
https://bugs.webkit.org/show_bug.cgi?id=64416
Summary Don't reuse the last InsertTextCommand
Ryosuke Niwa
Reported 2011-07-12 18:02:12 PDT
It seems unnecessary to reuse the last InsertTextCommand in TypingCommand. Changing the interface of InsertTextCommand to use doApply will make fixing the bug 64414 easier.
Attachments
Patch (9.62 KB, patch)
2011-07-12 18:09 PDT, Ryosuke Niwa 		justin.garcia: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2011-07-12 18:09:30 PDT
Created attachment 100601 [details] Patch
Hajime Morrita
Comment 2 2011-07-12 22:34:25 PDT
Comment on attachment 100601 [details] Patch Wow, I thought this reuse is for handling undo. But it isn't true....
Ryosuke Niwa
Comment 3 2011-07-12 23:22:14 PDT
(In reply to comment #2) > (From update of attachment 100601 [details]) > Wow, I thought this reuse is for handling undo. But it isn't true.... Undo/Redo is taken care by reusing TypingCommand. I'm guessing that this is an artifact of old days when InsertTextCommand was used differently than it is today.
Justin Garcia
Comment 4 2011-07-13 00:41:13 PDT
Comment on attachment 100601 [details] Patch Looks like you could get rid of: virtual bool isInsertTextCommand() const; as it is now unused.
Ryosuke Niwa
Comment 5 2011-07-13 00:42:57 PDT
Thanks for the review! (In reply to comment #4) > (From update of attachment 100601 [details]) > Looks like you could get rid of: > > virtual bool isInsertTextCommand() const; > > as it is now unused. Oh, you're right. I'll do that before I land.
Ryosuke Niwa
Comment 6 2011-07-13 10:55:24 PDT
Committed r90933: <http://trac.webkit.org/changeset/90933>
Note You need to log in before you can comment on or make changes to this bug.