Bug 64407 - garden-o-matic should display regression ranges
Summary: garden-o-matic should display regression ranges
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-12 16:16 PDT by Adam Barth
Modified: 2011-07-12 16:36 PDT (History)
3 users (show)

See Also:


Attachments
Patch (14.27 KB, patch)
2011-07-12 16:18 PDT, Adam Barth
no flags Details | Formatted Diff | Diff
Patch (14.27 KB, patch)
2011-07-12 16:29 PDT, Adam Barth
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2011-07-12 16:16:31 PDT
garden-o-matic should display regression ranges
Comment 1 Adam Barth 2011-07-12 16:18:22 PDT
Created attachment 100581 [details]
Patch
Comment 2 Dimitri Glazkov (Google) 2011-07-12 16:26:17 PDT
Comment on attachment 100581 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=100581&action=review

> Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/base.js:47
> +    return keys;

Could use Object.keys if available :)
Comment 3 Adam Barth 2011-07-12 16:29:29 PDT
Created attachment 100584 [details]
Patch
Comment 4 Adam Barth 2011-07-12 16:30:28 PDT
> Could use Object.keys if available :)

Yeah, I'm not sure which browser's we targeting.  :(
Comment 5 Adam Barth 2011-07-12 16:31:09 PDT
Committed r90866: <http://trac.webkit.org/changeset/90866>