WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
64397
Added the ability to dynamically change the parent context of a WebGraphicsContext3D.
https://bugs.webkit.org/show_bug.cgi?id=64397
Summary
Added the ability to dynamically change the parent context of a WebGraphicsCo...
Al
Reported
2011-07-12 14:45:20 PDT
Added the ability to dynamically change the parent context of a WebGraphicsContext3D. GraphicsContext3DInternal::platformTexture uses this to set the parent as appropriate. This is to fix the bug where a WebGL canvas cannot be moved to a newly opened window in Chrome.
Attachments
Patch
(2.06 KB, patch)
2011-07-12 14:46 PDT
,
Al
kbr
: review-
Details
Formatted Diff
Diff
Patch 2
(2.12 KB, patch)
2011-07-12 16:31 PDT
,
Al
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Al
Comment 1
2011-07-12 14:46:57 PDT
Created
attachment 100566
[details]
Patch
WebKit Review Bot
Comment 2
2011-07-12 14:49:06 PDT
Attachment 100566
[details]
did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/chromium/ChangeLog', u'Sourc..." exit_code: 1 Source/WebKit/chromium/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Source/WebKit/chromium/public/WebGraphicsContext3D.h:135: parent_context is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Total errors found: 2 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Kenneth Russell
Comment 3
2011-07-12 16:08:17 PDT
Comment on
attachment 100566
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=100566&action=review
Please clean up the style issues and re-upload the patch.
> Source/WebKit/chromium/src/GraphicsContext3DChromium.cpp:146 > + m_impl->setParentContext(m_webViewImpl->graphicsContext3D());
Does this still work if accelerated compositing is turned off (i.e., with the command line argument --disable-accelerated-compositing)?
Al
Comment 4
2011-07-12 16:31:34 PDT
Created
attachment 100585
[details]
Patch 2
Al
Comment 5
2011-07-12 16:32:50 PDT
Comment on
attachment 100566
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=100566&action=review
>> Source/WebKit/chromium/src/GraphicsContext3DChromium.cpp:146 >> + m_impl->setParentContext(m_webViewImpl->graphicsContext3D()); > > Does this still work if accelerated compositing is turned off (i.e., with the command line argument --disable-accelerated-compositing)?
Yeah. platformTexture doesn't get called when the accelerated compositor is turned off.
Kenneth Russell
Comment 6
2011-07-12 18:35:48 PDT
Comment on
attachment 100585
[details]
Patch 2 OK, seems fine as long as it's been tested.
WebKit Review Bot
Comment 7
2011-07-12 19:28:29 PDT
Comment on
attachment 100585
[details]
Patch 2 Clearing flags on attachment: 100585 Committed
r90878
: <
http://trac.webkit.org/changeset/90878
>
WebKit Review Bot
Comment 8
2011-07-12 19:28:34 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug