Bug 64394 - cr-linux-ews should run pixel tests
Summary: cr-linux-ews should run pixel tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-12 14:34 PDT by Adam Barth
Modified: 2011-07-12 15:35 PDT (History)
5 users (show)

See Also:


Attachments
Patch (3.41 KB, patch)
2011-07-12 14:36 PDT, Adam Barth
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2011-07-12 14:34:07 PDT
cr-linux-ews should run pixel tests
Comment 1 Adam Barth 2011-07-12 14:36:18 PDT
Created attachment 100564 [details]
Patch
Comment 2 Ojan Vafai 2011-07-12 14:39:35 PDT
Comment on attachment 100564 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=100564&action=review

> Tools/ChangeLog:9
> +        test on the bots, it looks like we have five pixel failures, related to

I'm confused, won't these 5 tests start failing on every run now?

> Tools/ChangeLog:11
> +        avoid uploading huge zip files to bugs.webkit.org (with all the exected

typo:exected
Comment 3 Adam Barth 2011-07-12 14:41:07 PDT
(In reply to comment #2)
> (From update of attachment 100564 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=100564&action=review
> 
> > Tools/ChangeLog:9
> > +        test on the bots, it looks like we have five pixel failures, related to
> 
> I'm confused, won't these 5 tests start failing on every run now?

Yes, but we have code to recognize persistent failures and ignore them.
Comment 4 Ojan Vafai 2011-07-12 14:42:13 PDT
Comment on attachment 100564 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=100564&action=review

>>> Tools/ChangeLog:9
>>> +        test on the bots, it looks like we have five pixel failures, related to
>> 
>> I'm confused, won't these 5 tests start failing on every run now?
> 
> Yes, but we have code to recognize persistent failures and ignore them.

That sounds scary.
Comment 5 Adam Barth 2011-07-12 14:52:59 PDT
(In reply to comment #4)
> (From update of attachment 100564 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=100564&action=review
> 
> >>> Tools/ChangeLog:9
> >>> +        test on the bots, it looks like we have five pixel failures, related to
> >> 
> >> I'm confused, won't these 5 tests start failing on every run now?
> > 
> > Yes, but we have code to recognize persistent failures and ignore them.
> 
> That sounds scary.

There's an upper bound on how many failures to ignore.  It's been working for us so far.  If it causes problems, we can re-evaluate later.
Comment 6 WebKit Review Bot 2011-07-12 15:35:41 PDT
Comment on attachment 100564 [details]
Patch

Clearing flags on attachment: 100564

Committed r90864: <http://trac.webkit.org/changeset/90864>
Comment 7 WebKit Review Bot 2011-07-12 15:35:46 PDT
All reviewed patches have been landed.  Closing bug.