Bug 64392 – Caret should move immediately before a word when modifying selection by word granularity on Windows

• Status: RESOLVED
• Resolution: FIXED
• Component: HTML Editing

[David Tseng]

1.  place focus on a textfield or textarea (i.e. google.com, search field).
2.  type a sentence (i.e. "this is a test").
3.  press ctrl-right several times and then ctrl-left several times.

What is the expected result?
each press of ctrl-right places cursor before next word.  Example:
this |is a test.
this is |a test.
this is a |test.

Currently, webkit places the cursor *after* the current word.
this| is a test.
this is| a test.
this is a| test.

This though consistent with Mac cursor movement, isn't in Windows.

[Ryosuke Niwa]

http://crbug.com/88711

[David Tseng]

Created attachment 101393 [details]
Proposed patch.

[Ryosuke Niwa]

Comment on attachment 101393 [details]
Proposed patch.

We definitely need a test for this.

[Ryosuke Niwa]

Comment on attachment 101393 [details]
Proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=101393&action=review

> Source/WebCore/platform/text/TextBoundaries.cpp:74
> -            if (position < len && isAlphanumeric(chars[position - 1]))
> +            if (position < len && isAlphanumeric(chars[position]))

This code seems to be used by GTK as well.  Are we sure we want this behavior on GTK?

[Darin Adler]

Comment on attachment 101393 [details]
Proposed patch.

I don’t think this is the right level to make this policy change.

Further, this should probably be a behavior change that is conditional based on text editing behavior. It’s a coincidence right now that this code isn’t used on Mac, for example.

[Ryosuke Niwa]

(In reply to comment #5)
> (From update of attachment 101393 [details])
> I don’t think this is the right level to make this policy change.
> 
> Further, this should probably be a behavior change that is conditional based on text editing behavior. It’s a coincidence right now that this code isn’t used on Mac, for example.

I agree. Changing behavior based on EditingBehavior is much cleaner.

[Ryosuke Niwa]

Comment on attachment 101393 [details]
Proposed patch.

Clearing cq? since this patch has been r-ed.

[Ryosuke Niwa]

Xiaomei, is this bug fixed per your visual word movement patch?

[Xiaomei Ji]

(In reply to comment #8)
> Xiaomei, is this bug fixed per your visual word movement patch?

Yes. and I am closing it.