Bug 64381 - Isolate HTMLTextFormControlElement into a separate file
Summary: Isolate HTMLTextFormControlElement into a separate file
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-12 12:45 PDT by Ryosuke Niwa
Modified: 2011-07-12 14:20 PDT (History)
7 users (show)

See Also:


Attachments
Patch (114.33 KB, patch)
2011-07-12 12:54 PDT, Ryosuke Niwa
no flags Details | Formatted Diff | Diff
Fixed include in HTMLTextFormControlElement.cpp (114.40 KB, patch)
2011-07-12 12:58 PDT, Ryosuke Niwa
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ec2-cr-linux-01 (1.28 MB, application/zip)
2011-07-12 13:21 PDT, WebKit Review Bot
no flags Details
fixed test failures (122.13 KB, patch)
2011-07-12 13:59 PDT, Ryosuke Niwa
dglazkov: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2011-07-12 12:45:00 PDT
HTMLFormControlElement.h:
// FIXME: Give this class its own header file.
class HTMLTextFormControlElement : public HTMLFormControlElementWithState {

Let's do it.
Comment 1 Eric Seidel (no email) 2011-07-12 12:46:06 PDT
You are a brave man.  Adding files to the project is so painful. :(
Comment 2 Ryosuke Niwa 2011-07-12 12:54:17 PDT
Created attachment 100543 [details]
Patch
Comment 3 Ryosuke Niwa 2011-07-12 12:56:10 PDT
The patch is gigantic because I svn cp'ed HTMLFormControlElement.h and HTMLFormControlElement.cpp but this should be a long-term win 'cause it preserve svn blame list.
Comment 4 WebKit Review Bot 2011-07-12 12:56:28 PDT
Attachment 100543 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/W..." exit_code: 1

Source/WebCore/html/HTMLTextFormControlElement.cpp:26:  Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Source/WebCore/html/HTMLTextFormControlElement.cpp:28:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 2 in 15 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Ryosuke Niwa 2011-07-12 12:58:35 PDT
Created attachment 100546 [details]
Fixed include in HTMLTextFormControlElement.cpp
Comment 6 Ryosuke Niwa 2011-07-12 12:59:13 PDT
Comment on attachment 100546 [details]
Fixed include in HTMLTextFormControlElement.cpp

Oops, HTMLTextFormControlElement.cpp was including HTMLFormControlElement.h instead of HTMLTextFormControlElement.h.
Comment 7 WebKit Review Bot 2011-07-12 13:21:15 PDT
Comment on attachment 100546 [details]
Fixed include in HTMLTextFormControlElement.cpp

Attachment 100546 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/9022251

New failing tests:
editing/pasteboard/drag-drop-input-textarea.html
editing/pasteboard/drop-text-events.html
editing/pasteboard/copy-backslash-with-euc.html
editing/input/div-first-child-rule-textarea.html
editing/input/ime-composition-clearpreedit.html
editing/input/insert-wrapping-space-in-textarea.html
editing/selection/delete-word-granularity-text-control.html
editing/input/set-value-on-input-and-type-input.html
editing/input/set-value-on-input-and-type-textarea.html
editing/input/set-value-on-input-and-delete.html
editing/deleting/delete-ligature-001.html
editing/deleting/5290534.html
editing/pasteboard/paste-text-events.html
editing/inserting/typing-tab-designmode-forms.html
editing/input/div-first-child-rule-input.html
editing/pasteboard/copy-null-characters.html
editing/spelling/spellcheck-paste.html
editing/undo/5658727.html
editing/pasteboard/drag-drop-url-text.html
editing/selection/drag-text-delay.html
Comment 8 WebKit Review Bot 2011-07-12 13:21:19 PDT
Created attachment 100550 [details]
Archive of layout-test-results from ec2-cr-linux-01

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-01  Port: Chromium  Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Comment 9 Ryosuke Niwa 2011-07-12 13:59:51 PDT
Created attachment 100555 [details]
fixed test failures
Comment 10 Ryosuke Niwa 2011-07-12 14:01:34 PDT
I forgot to replace calls to HTMLFormControlElementWithState::defaultEventHandler by calls to HTMLTextFormControlElement::defaultEventHandler.  Fixed this and now tests pass.
Comment 11 Ryosuke Niwa 2011-07-12 14:14:49 PDT
Thanks for the review, Dimitri!
Comment 12 Ryosuke Niwa 2011-07-12 14:20:40 PDT
Committed r90849: <http://trac.webkit.org/changeset/90849>