Bug 64379 – Web Inspector: do not pause on caught exceptions while typing in the console.

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Pavel Feldman]

If user has pauseOnExceptions set to "uncaught", typing in the console may stop in the injected script. Should not.

[Pavel Feldman]

Created attachment 100539 [details]
Patch

[WebKit Review Bot]

Attachment 100539 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebCore/inspector/InspectorRuntimeAgent.h:56:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/inspector/InspectorRuntimeAgent.cpp:60:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Total errors found: 2 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Yury Semikhatsky]

Comment on attachment 100539 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=100539&action=review

r- as WorkerInspectoController also needs change.

> Source/WebCore/inspector/InspectorController.cpp:132
> +    m_runtimeAgent->setScriptDebugServer(&m_debuggerAgent->scriptDebugServer());

Let's pass reference to ScriptDebugServer into the InspectorRuntimeAgent constructor. This way compiler will check all call sites and ensure that ScriptDebugServer is never null.

[Yury Semikhatsky]

Comment on attachment 100539 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=100539&action=review

> Source/WebCore/inspector/InspectorRuntimeAgent.cpp:42
> +#if ENABLE(JAVASCRIPT_DEBUGGER)

No need to embrace #include wtih #if ENABLE guard.

[Pavel Feldman]

(In reply to comment #3)
> (From update of attachment 100539 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=100539&action=review
> 
> r- as WorkerInspectoController also needs change.
> 
> > Source/WebCore/inspector/InspectorController.cpp:132
> > +    m_runtimeAgent->setScriptDebugServer(&m_debuggerAgent->scriptDebugServer());
> 
> Let's pass reference to ScriptDebugServer into the InspectorRuntimeAgent constructor. This way compiler will check all call sites and ensure that ScriptDebugServer is never null.

There are two ancestors of runtime agent (Page and Worker). Doing what you suggest will add ifdefs into three corresponding classes. It will also make their constructors receive different parameters depending on the DEBUGGER definition. It all kills readability.

[Pavel Feldman]

Created attachment 101138 [details]
Patch

[WebKit Review Bot]

Attachment 101138 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebCore/inspector/InspectorRuntimeAgent.h:56:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Source/WebCore/inspector/InspectorRuntimeAgent.cpp:60:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Total errors found: 2 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Pavel Feldman]

Committed r91176: <http://trac.webkit.org/changeset/91176>

[Pavel Feldman]

*** Bug 64684 has been marked as a duplicate of this bug. ***