Bug 64358 - TestFailures page thinks all tests passed in http://build.webkit.org/builders/Windows%207%20Release%20(Tests)/builds/14672
Summary: TestFailures page thinks all tests passed in http://build.webkit.org/builders...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Roben (:aroben)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-12 07:13 PDT by Adam Roben (:aroben)
Modified: 2011-07-12 11:03 PDT (History)
4 users (show)

See Also:

Attachments
Patch (7.59 KB, patch)
2011-07-12 07:14 PDT, Adam Roben (:aroben) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Roben (:aroben) 2011-07-12 07:13:15 PDT 
TestFailures page thinks all tests passed in http://build.webkit.org/builders/Windows%207%20Release%20(Tests)/builds/14672
Comment 1 Adam Roben (:aroben) 2011-07-12 07:14:18 PDT 
Created attachment 100481 [details]
Patch
Comment 2 Daniel Bates 2011-07-12 10:08:29 PDT 
Comment on attachment 100481 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=100481&action=review

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:156
> +                result.failureCount = -1;

I take it that you've ensured that the callsites can handle failureCount = -1. Briefly looking through the code this appears to be true.
Comment 3 WebKit Review Bot 2011-07-12 10:51:13 PDT 
Comment on attachment 100481 [details]
Patch

Clearing flags on attachment: 100481

Committed r90824: <http://trac.webkit.org/changeset/90824>
Comment 4 WebKit Review Bot 2011-07-12 10:51:18 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Adam Roben (:aroben) 2011-07-12 11:03:37 PDT 
Comment on attachment 100481 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=100481&action=review

>> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:156
>> +                result.failureCount = -1;
> 
> I take it that you've ensured that the callsites can handle failureCount = -1. Briefly looking through the code this appears to be true.

Yes. It was already possible for this function to return -1 in some cases, so callers have been expecting it for a while.