Bug 64357 - [Qt] Forward the touch view scale changes to the tiled drawing area.
Summary: [Qt] Forward the touch view scale changes to the tiled drawing area.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jocelyn Turcotte
URL:
Keywords: Qt, QtTriaged
Depends on:
Blocks:
 
Reported: 2011-07-12 07:07 PDT by Jocelyn Turcotte
Modified: 2011-07-13 02:50 PDT (History)
2 users (show)

See Also:


Attachments
Patch (3.71 KB, patch)
2011-07-12 07:10 PDT, Jocelyn Turcotte
no flags Details | Formatted Diff | Diff
Patch (for comment #4) (1.57 KB, patch)
2011-07-12 08:05 PDT, Jocelyn Turcotte
benjamin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jocelyn Turcotte 2011-07-12 07:07:33 PDT
[Qt] Forward the touch view scale changes to the tiled drawing area.
Comment 1 Jocelyn Turcotte 2011-07-12 07:10:30 PDT
Created attachment 100480 [details]
Patch
Comment 2 Kenneth Rohde Christiansen 2011-07-12 07:15:51 PDT
Comment on attachment 100480 [details]
Patch

This looks good
Comment 3 Benjamin Poulain 2011-07-12 07:17:16 PDT
Comment on attachment 100480 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=100480&action=review

> Source/WebKit2/UIProcess/qt/qtouchwebpageproxy.cpp:104
> +void QTouchWebPageProxy::setContentsScale(float scale)

should be qreal.
Comment 4 Benjamin Poulain 2011-07-12 07:26:57 PDT
Comment on attachment 100480 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=100480&action=review

> Source/WebKit2/UIProcess/API/qt/qtouchwebpage.cpp:182
> +    page->setContentsScale(q->scale());

I would prefer you stop the m_scaleCommitTimer here instead of in QTouchWebPage::timerEvent().
Otherwise it might timeout after the commitScaleChange and you get a second call commitScaleChange, and the assertion would fail.
Comment 5 Kenneth Rohde Christiansen 2011-07-12 07:37:10 PDT
(In reply to comment #3)
> (From update of attachment 100480 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=100480&action=review
> 
> > Source/WebKit2/UIProcess/qt/qtouchwebpageproxy.cpp:104
> > +void QTouchWebPageProxy::setContentsScale(float scale)
> 
> should be qreal.

Tis is why I found it confusing with mixing webcore and qt types :-(
Comment 6 Jocelyn Turcotte 2011-07-12 07:45:00 PDT
Committed r90817: <http://trac.webkit.org/changeset/90817>
Comment 7 Jocelyn Turcotte 2011-07-12 07:47:50 PDT
Reopening to address comment #4.
Comment 8 Jocelyn Turcotte 2011-07-12 08:05:18 PDT
Created attachment 100486 [details]
Patch (for comment #4)

Patch that addresses comment #4 since I already pushed the fixed that was momentarily r+ed.
(The qreal fix was done before pushing)
Comment 9 Jocelyn Turcotte 2011-07-13 02:50:39 PDT
Committed r90899: <http://trac.webkit.org/changeset/90899>