Bug 64357 – [Qt] Forward the touch view scale changes to the tiled drawing area.

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Jocelyn Turcotte]

[Qt] Forward the touch view scale changes to the tiled drawing area.

[Jocelyn Turcotte]

Created attachment 100480 [details]
Patch

[Kenneth Rohde Christiansen]

Comment on attachment 100480 [details]
Patch

This looks good

[Benjamin Poulain]

Comment on attachment 100480 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=100480&action=review

> Source/WebKit2/UIProcess/qt/qtouchwebpageproxy.cpp:104
> +void QTouchWebPageProxy::setContentsScale(float scale)

should be qreal.

[Benjamin Poulain]

Comment on attachment 100480 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=100480&action=review

> Source/WebKit2/UIProcess/API/qt/qtouchwebpage.cpp:182
> +    page->setContentsScale(q->scale());

I would prefer you stop the m_scaleCommitTimer here instead of in QTouchWebPage::timerEvent().
Otherwise it might timeout after the commitScaleChange and you get a second call commitScaleChange, and the assertion would fail.

[Kenneth Rohde Christiansen]

(In reply to comment #3)
> (From update of attachment 100480 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=100480&action=review
> 
> > Source/WebKit2/UIProcess/qt/qtouchwebpageproxy.cpp:104
> > +void QTouchWebPageProxy::setContentsScale(float scale)
> 
> should be qreal.

Tis is why I found it confusing with mixing webcore and qt types :-(

[Jocelyn Turcotte]

Committed r90817: <http://trac.webkit.org/changeset/90817>

[Jocelyn Turcotte]

Reopening to address comment #4.

[Jocelyn Turcotte]

Created attachment 100486 [details]
Patch (for comment #4)

Patch that addresses comment #4 since I already pushed the fixed that was momentarily r+ed.
(The qreal fix was done before pushing)

[Jocelyn Turcotte]

Committed r90899: <http://trac.webkit.org/changeset/90899>