Bug 64354 - [EFL] Implement EFL-specific current time and monotonicallyIncreasingTime.
Summary: [EFL] Implement EFL-specific current time and monotonicallyIncreasingTime.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryuan Choi
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-12 05:34 PDT by Ryuan Choi
Modified: 2011-07-25 00:19 PDT (History)
5 users (show)

See Also:


Attachments
Patch (1.93 KB, patch)
2011-07-12 20:56 PDT, Ryuan Choi
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryuan Choi 2011-07-12 05:34:14 PDT
Patch will be added.
Comment 1 Ryuan Choi 2011-07-12 20:56:48 PDT
Created attachment 100618 [details]
Patch
Comment 2 Gyuyoung Kim 2011-07-12 23:04:42 PDT
Comment on attachment 100618 [details]
Patch

Did you test this functions ?
Comment 3 Ryuan Choi 2011-07-13 00:13:50 PDT
(In reply to comment #2)
> (From update of attachment 100618 [details])
> Did you test this functions ?

I tested gettimeofday version and ecore_time_unix_get.
They return almost same value.
(little bit different because time elapsed after calling one and other).

In case of ecore_time_get, you can reference below document.
http://docs.enlightenment.org/auto/ecore/group__Ecore__Time__Group.html#ga43846b079394bb4d098abf5c16dfc544

Because ecore_time_get use monotonic clock, it cover functionality of monotonicallyIncreasingTime.
Comment 4 Gyuyoung Kim 2011-07-13 03:03:02 PDT
(In reply to comment #3)
> (In reply to comment #2)
> > (From update of attachment 100618 [details] [details])
> > Did you test this functions ?
> 
> I tested gettimeofday version and ecore_time_unix_get.
> They return almost same value.
> (little bit different because time elapsed after calling one and other).
> 
> In case of ecore_time_get, you can reference below document.
> http://docs.enlightenment.org/auto/ecore/group__Ecore__Time__Group.html#ga43846b079394bb4d098abf5c16dfc544
> 
> Because ecore_time_get use monotonic clock, it cover functionality of monotonicallyIncreasingTime.

Implementation of ecore_time_unix_get() uses gettimeofday as well. So, it looks there is no problem.
Comment 5 Raphael Kubo da Costa (:rakuco) 2011-07-13 06:55:21 PDT
LGTM.
Comment 6 WebKit Review Bot 2011-07-25 00:19:04 PDT
Comment on attachment 100618 [details]
Patch

Clearing flags on attachment: 100618

Committed r91660: <http://trac.webkit.org/changeset/91660>
Comment 7 WebKit Review Bot 2011-07-25 00:19:10 PDT
All reviewed patches have been landed.  Closing bug.