Bug 64348 - Unquoted string "attributes" may clash with future reserved word at ../../Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm line 1058.
Summary: Unquoted string "attributes" may clash with future reserved word at ../../Sou...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-12 01:36 PDT by arno.
Modified: 2011-10-17 16:14 PDT (History)
4 users (show)

See Also:

Attachments
patch (1.63 KB, patch)
2011-07-12 01:48 PDT, arno. 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description arno. 2011-07-12 01:36:35 PDT 
Hi,
when building webkit-gtk with annotations, warning is issued multiple times from CodeGeneratorGObject.pm
Comment 1 arno. 2011-07-12 01:48:42 PDT 
Created attachment 100450 [details]
patch
Comment 2 Eric Seidel (no email) 2011-09-12 17:02:50 PDT 
Comment on attachment 100450 [details]
patch

Huh?  I'm confused by this perl.
Comment 3 Darin Adler 2011-10-17 09:33:11 PDT 
Comment on attachment 100450 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=100450&action=review

> Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm:1058
> -        $param->extendedAttributes(attributes);
> +        $param->extendedAttributes("attributes");

After reviewing, I realized that I don’t really understand this line. It looks like it fetches a value that is never used.
Comment 4 WebKit Review Bot 2011-10-17 16:14:08 PDT 
Comment on attachment 100450 [details]
patch

Clearing flags on attachment: 100450

Committed r97664: <http://trac.webkit.org/changeset/97664>
Comment 5 WebKit Review Bot 2011-10-17 16:14:14 PDT 
All reviewed patches have been landed.  Closing bug.