Bug 64324 - webkit-patch roll-chromium-deps no longer works
Summary: webkit-patch roll-chromium-deps no longer works
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-11 16:30 PDT by Ryosuke Niwa
Modified: 2011-07-11 16:35 PDT (History)
2 users (show)

See Also:


Attachments
Patch (1.49 KB, patch)
2011-07-11 16:32 PDT, Ryosuke Niwa
jamesr: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2011-07-11 16:30:46 PDT
webkit-patch roll-chromium-deps blows up with the following trace:

  File "Tools/Scripts/webkit-patch", line 66, in <module>
    main()
  File "Tools/Scripts/webkit-patch", line 61, in main
    WebKitPatch(__file__).main()
  File "/Volumes/Data/webkit2/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 308, in main
    result = command.check_arguments_and_execute(options, args, self)
  File "/Volumes/Data/webkit2/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 117, in check_arguments_and_execute
    return self.execute(options, args, tool) or 0
  File "/Volumes/Data/webkit2/Tools/Scripts/webkitpy/tool/commands/abstractsequencedcommand.py", line 51, in execute
    self._sequence.run_and_handle_errors(tool, options, state)
  File "/Volumes/Data/webkit2/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 70, in run_and_handle_errors
    self._run(tool, options, state)
  File "/Volumes/Data/webkit2/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 64, in _run
    step(tool, options).run(state)
  File "/Volumes/Data/webkit2/Tools/Scripts/webkitpy/tool/steps/commit.py", line 48, in run
    raise Exception("Attempted to commit with a commit message shorter than 50 characters.  Either your patch is missing a ChangeLog or webkit-patch may have a bug.")
Comment 1 Ryosuke Niwa 2011-07-11 16:32:32 PDT
Created attachment 100379 [details]
Patch
Comment 2 Adam Barth 2011-07-11 16:33:06 PDT
Comment on attachment 100379 [details]
Patch

Did you run test-webkitpy?
Comment 3 James Robinson 2011-07-11 16:33:31 PDT
Comment on attachment 100379 [details]
Patch

R=me but please file a bug to make this check actually do what it claims it's trying to do (checking for a ChangeLog on the patch).
Comment 4 Ryosuke Niwa 2011-07-11 16:35:17 PDT
Committed r90793: <http://trac.webkit.org/changeset/90793>