Bug 64308 - [Chromium] Upstream 2 layout test failures.
Summary: [Chromium] Upstream 2 layout test failures.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-11 12:34 PDT by Jeff Timanus
Modified: 2011-07-12 11:06 PDT (History)
5 users (show)

See Also:

Attachments
Patch (1.28 KB, patch)
2011-07-11 15:18 PDT, Jeff Timanus 		no flags Details | Formatted Diff | Diff
Patch (2.37 KB, patch)
2011-07-12 10:33 PDT, Jeff Timanus 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jeff Timanus 2011-07-11 12:34:26 PDT 
Skia roll r1814:r1832 potentially introduced the following crashes (WIN-only):

  svg/dynamic-updates/SVGFEDropShadowElement-svgdom-dy-prop.html = CRASH
  svg/dynamic-updates/SVGFEFloodElement-dom-flood-color-attr.html = CRASH

More investigation is required to determine if the tests were flaky before the skia roll.

Tracked via crbug.com\88801
Comment 1 Jeff Timanus 2011-07-11 15:18:44 PDT 
Created attachment 100368 [details]
Patch
Comment 2 Stephen White 2011-07-11 15:22:25 PDT 
Comment on attachment 100368 [details]
Patch

Looks good. r=me
Comment 3 Stephen White 2011-07-11 15:23:21 PDT 
Comment on attachment 100368 [details]
Patch

Oops, looks like your patch is out of date.
Comment 4 Jeff Timanus 2011-07-12 10:33:51 PDT 
Created attachment 100508 [details]
Patch
Comment 5 Stephen White 2011-07-12 10:49:33 PDT 
Comment on attachment 100508 [details]
Patch

Looks good.  r=me
Comment 6 WebKit Review Bot 2011-07-12 11:06:26 PDT 
Comment on attachment 100508 [details]
Patch

Clearing flags on attachment: 100508

Committed r90828: <http://trac.webkit.org/changeset/90828>
Comment 7 WebKit Review Bot 2011-07-12 11:06:31 PDT 
All reviewed patches have been landed.  Closing bug.