RESOLVED FIXED 64289
[Qt][WK2] Get rid of focusNextPrevChild() 
https://bugs.webkit.org/show_bug.cgi?id=64289
Summary [Qt][WK2] Get rid of focusNextPrevChild()
Benjamin Poulain
Reported 2011-07-11 09:20:45 PDT
Qt 5 does not support focusNextPrevChild(). We should get rid of that for now.
Attachments
Patch (4.34 KB, patch)
2011-07-11 09:32 PDT, Benjamin Poulain 		kling: review+
kling: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Benjamin Poulain
Comment 1 2011-07-11 09:32:20 PDT
Created attachment 100312 [details] Patch
Andreas Kling
Comment 2 2011-07-11 09:38:50 PDT
Comment on attachment 100312 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=100312&action=review r=me. > Source/WebKit2/UIProcess/qt/ClientImpl.cpp:172 > void qt_wk_takeFocus(WKPageRef page, WKFocusDirection direction, const void *clientInfo) You could get rid of this ClientImpl method.
Andreas Kling
Comment 3 2011-07-11 10:10:55 PDT
Comment on attachment 100312 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=100312&action=review You asked for it.. > Source/WebKit2/ChangeLog:3 > + [Qt][WK2] Get rid of the focusNextPrevChild() s/the//
Benjamin Poulain
Comment 4 2011-07-11 11:22:38 PDT
Committed r90766: <http://trac.webkit.org/changeset/90766>
Note You need to log in before you can comment on or make changes to this bug.