Bug 64287 – Web Inspector: Network panel search needs each resource to have unique identifier.

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Vsevolod Vlasov]

Network panel search needs each resource to have unique identifier.

[Vsevolod Vlasov]

Created attachment 100310 [details]
Patch

[Ilya Tikhonovsky]

Comment on attachment 100310 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=100310&action=review

> Source/WebCore/inspector/front-end/NetworkPanel.js:1158
> +        if (this._matchedResourcesMap[resource.identifier]) {
> +            this._matchedResourcesMap[oldResource.identifier] = this._matchedResourcesMap[resource.identifier];
> +            delete this._matchedResourcesMap[resource.identifier];
> +        }
> +        for (var i = 0; i < this._matchedResources.length; i++) {
> +            if (this._matchedResources[i] === resource.identifier)
> +                this._matchedResources[i] = oldResource.identifier;
> +        }

As far as the value in this._matchedResourcesMap[resource.identifier] is the index of resource in this._matchedResources
you can use it instead of iterating over this._matchedResources array.

[Vsevolod Vlasov]

Created attachment 100474 [details]
Patch with fixes

[Vsevolod Vlasov]

Created attachment 100477 [details]
Patch with fixes2

[WebKit Review Bot]

Comment on attachment 100477 [details]
Patch with fixes2

Clearing flags on attachment: 100477

Committed r90913: <http://trac.webkit.org/changeset/90913>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.