In bug 63330, attachment 99745 [details] failed to build on the Windows EWS. You can see this by the red "win" box underneath the patch. But you can also see that there's no comment in the bug indicating that the patch failed to build.
I wonder what happened here?
Can you grab the logs from the bot?
I checked all of the EWS bots and this log file does not exist.
This looks like the log?
This is the attachment page:
I just clicked on the bubble next to the attachment, I assume you all did the same, so I must be missing something here.
29>gtest.lib(gtest.obj) : warning LNK4075: ignoring '/EDITANDCONTINUE' due to '/SAFESEH' specification
29>LINK : warning LNK4098: defaultlib 'MSVCRTD' conflicts with use of other libs; use /NODEFAULTLIB:library
29>StringOperators.obj : error LNK2019: unresolved external symbol "public: __thiscall WTF::String::String(char const *)" (??0String@WTF@@QAE@PBD@Z) referenced in function "private: virtual void __thiscall TestWebKitAPI::WTF_StringOperators_Test::TestBody(void)" (?TestBody@WTF_StringOperators_Test@TestWebKitAPI@@EAEXXZ)
29>StringOperators.obj : error LNK2019: unresolved external symbol "private: static class WTF::PassRefPtr<class WTF::StringImpl> __cdecl WTF::AtomicString::add(char const *)" (?add@AtomicString@WTF@@CA?AV?$PassRefPtr@VStringImpl@WTF@@@2@PBD@Z) referenced in function "public: __thiscall WTF::AtomicString::AtomicString(char const *)" (??0AtomicString@WTF@@QAE@PBD@Z)
29>C:\cygwin\home\buildbot\Webkit\WebKitBuild\Debug\bin\TestWebKitAPI.exe : fatal error LNK1120: 2 unresolved externals
29>Build log was saved at "file://C:\cygwin\home\buildbot\Webkit\WebKitBuild\Debug\obj\TestWebKitAPI\BuildLog.htm"
29>TestWebKitAPI - 3 error(s), 2 warning(s)
is the error I see?
Oh, I see now. You're wondering why the win-ews didn't comment? Bugzilla was down for a while this weekend, it's possible it was down briefly when this thing tried to build 5 days ago. Not sure why we don't see logs of the build event though.
I can change the patch status page to include information on where the log message came from if that would help?
It should really just use this include instead of rolling its own:
(In reply to comment #5)
> You're wondering why the win-ews didn't comment?
> Bugzilla was down for a while this weekend, it's possible it was down briefly when this thing tried to build 5 days ago. Not sure why we don't see logs of the build event though.
I uploaded attachment 99745 [details] almost a week ago. I'd assume that the EWS bot processed well before this weekend.
Yes, it processed your patch 5 days, 21 hours ago. http://queues.webkit.org/patch/99745