Bug 64274 - Web Inspector: make SourceFrame a View.
Summary: Web Inspector: make SourceFrame a View.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Podivilov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-11 06:23 PDT by Pavel Podivilov
Modified: 2011-07-11 10:53 PDT (History)
13 users (show)

See Also:


Attachments
Patch. (6.35 KB, patch)
2011-07-11 06:24 PDT, Pavel Podivilov
pfeldman: review-
Details | Formatted Diff | Diff
Patch. (9.72 KB, patch)
2011-07-11 06:49 PDT, Pavel Podivilov
pfeldman: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ec2-cr-linux-03 (1.70 MB, application/zip)
2011-07-11 07:05 PDT, WebKit Review Bot
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Podivilov 2011-07-11 06:23:32 PDT
Web Inspector: make SourceFrame a View.
Comment 1 Pavel Podivilov 2011-07-11 06:24:14 PDT
Created attachment 100287 [details]
Patch.
Comment 2 Pavel Feldman 2011-07-11 06:40:34 PDT
Comment on attachment 100287 [details]
Patch.

This patch looks wrong.
Comment 3 Pavel Podivilov 2011-07-11 06:49:22 PDT
Created attachment 100292 [details]
Patch.
Comment 4 WebKit Review Bot 2011-07-11 07:05:53 PDT
Comment on attachment 100292 [details]
Patch.

Attachment 100292 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/9012446

New failing tests:
http/tests/misc/slow-loading-mask.html
fast/blockflow/japanese-rl-selection.html
svg/transforms/text-with-mask-with-svg-transform.svg
fast/backgrounds/background-leakage.html
fast/box-shadow/scaled-box-shadow.html
fast/backgrounds/repeat/negative-offset-repeat.html
svg/W3C-SVG-1.1/struct-use-01-t.svg
transforms/2d/hindi-rotated.html
inspector/debugger/live-edit.html
svg/repaint/filter-repaint.svg
fast/blockflow/japanese-lr-selection.html
Comment 5 WebKit Review Bot 2011-07-11 07:05:57 PDT
Created attachment 100294 [details]
Archive of layout-test-results from ec2-cr-linux-03

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-03  Port: Chromium  Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Comment 6 Pavel Podivilov 2011-07-11 07:09:41 PDT
Committed r90743: <http://trac.webkit.org/changeset/90743>
Comment 7 Adam Barth 2011-07-11 10:49:45 PDT
Were these failures not real?
Comment 8 Pavel Podivilov 2011-07-11 10:52:53 PDT
(In reply to comment #7)
> Were these failures not real?

Looks so, except for the inspector/debugger/live-edit.html.
Comment 9 Adam Barth 2011-07-11 10:53:56 PDT
Thanks.  Looks like the bot might be sick.