Bug 64261 - Fix the condition of the optimized code in doubleTransfer
Summary: Fix the condition of the optimized code in doubleTransfer
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-11 04:36 PDT by Gabor Loki
Modified: 2011-07-11 10:23 PDT (History)
2 users (show)

See Also:

Attachments
Fix the condition of the optimized code in doubleTransfer (2.38 KB, patch)
2011-07-11 04:38 PDT, Gabor Loki 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gabor Loki 2011-07-11 04:36:14 PDT 
The condition of the optimized code in doubleTransfer is wrong on ARM.
The data transfer should be executed with four bytes aligned address.
VFP cannot perform unaligned memory access.
Comment 1 Gabor Loki 2011-07-11 04:38:06 PDT 
Created attachment 100265 [details]
Fix the condition of the optimized code in doubleTransfer
Comment 2 Zoltan Herczeg 2011-07-11 04:50:32 PDT 
Comment on attachment 100265 [details]
Fix the condition of the optimized code in doubleTransfer

Nice catch.
Comment 3 WebKit Review Bot 2011-07-11 05:32:31 PDT 
Comment on attachment 100265 [details]
Fix the condition of the optimized code in doubleTransfer

Clearing flags on attachment: 100265

Committed r90738: <http://trac.webkit.org/changeset/90738>
Comment 4 WebKit Review Bot 2011-07-11 05:32:35 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Alexey Proskuryakov 2011-07-11 10:18:54 PDT 
Regression test?
Comment 6 Zoltan Herczeg 2011-07-11 10:23:06 PDT 
(In reply to comment #5)
> Regression test?

Basically all math tests are regression tests. This was a typo, which prevented to use the fast path on ARM, and generated multiple instructions even when one is enough.