RESOLVED DUPLICATE of bug 6429564234
[Chromium] Keep alive popup menu object in handleMouseReleaseEvent not to crash.
https://bugs.webkit.org/show_bug.cgi?id=64234
Summary [Chromium] Keep alive popup menu object in handleMouseReleaseEvent not to crash.
Naoki Takano
Reported 2011-07-09 11:21:40 PDT
[Chromium]Keep alive popup menu object in handleMouseReleaseEvent not to crash.
Attachments
Patch (1.82 KB, patch)
2011-07-09 11:27 PDT, Naoki Takano
no flags
Naoki Takano
Comment 1 2011-07-09 11:27:02 PDT
Dmitry Lomov
Comment 2 2011-07-09 11:39:41 PDT
Drive-by comments (I )
Dmitry Lomov
Comment 3 2011-07-09 11:47:57 PDT
Drive-by comments: 1) Could we add a comment on acceptIndex stating that it can delete us? 2) Could we make sure that if acceptIndex deletes us, it returns false? My understanding is that if we are deleted, there is no point in dispatching any events to focused node, is it?
Naoki Takano
Comment 4 2011-07-11 18:05:21 PDT
1) So the comment would be "This function would delete this instance." Or do you have any other suggestion? 2) Can we detect the deletion? (In reply to comment #3) > Drive-by comments: > > 1) Could we add a comment on acceptIndex stating that it can delete us? > 2) Could we make sure that if acceptIndex deletes us, it returns false? My understanding is that if we are deleted, there is no point in dispatching any events to focused node, is it?
Dmitry Lomov
Comment 5 2011-07-12 03:25:15 PDT
(In reply to comment #4) > 1) So the comment would be "This function would delete this instance." Or do you have any other suggestion? > > 2) Can we detect the deletion? > > (In reply to comment #3) > > Drive-by comments: > > > > 1) Could we add a comment on acceptIndex stating that it can delete us? > > 2) Could we make sure that if acceptIndex deletes us, it returns false? My understanding is that if we are deleted, there is no point in dispatching any events to focused node, is it? I am not vary familiar with this code, so maybe someone else can comment?
Naoki Takano
Comment 6 2011-07-12 22:55:01 PDT
*** This bug has been marked as a duplicate of bug 64295 ***
Note You need to log in before you can comment on or make changes to this bug.