WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
NEW
64226
check-webkit-style should maybe use pylint instead of pep8
https://bugs.webkit.org/show_bug.cgi?id=64226
Summary
check-webkit-style should maybe use pylint instead of pep8
Dirk Pranke
Reported
2011-07-08 18:53:27 PDT
Pylint catches a whole lot more things than PEP-8 does (although it's quite a bit slower). We could consider pyflakes as an alternative as well, but I think we should favor comprehensiveness over speed unless demonstrated to be a problem.
Attachments
Add attachment
proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1
2011-07-09 03:38:27 PDT
I think we just want to add more pre-upload steps besides check-webkit-style. Maybe a check-patch command which runs a whoel bunch of these.
Adam Roben (:aroben)
Comment 2
2011-07-09 12:07:24 PDT
What kinds of things do these other tools check for that pep8 doesn't?
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug