Bug 64212 - REGRESSION(r90662): Chromium gtests exposed a bug where we return the end value for selectionStart (Requested by ojan on #webkit).
Summary: REGRESSION(r90662): Chromium gtests exposed a bug where we return the end val...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: WebKit Commit Bot
URL:
Keywords:
Depends on:
Blocks: 64133
  Show dependency treegraph
 
Reported: 2011-07-08 15:56 PDT by WebKit Commit Bot
Modified: 2011-07-11 10:59 PDT (History)
3 users (show)

See Also:


Attachments
ROLLOUT of r90662 (21.95 KB, patch)
2011-07-08 15:56 PDT, WebKit Commit Bot
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description WebKit Commit Bot 2011-07-08 15:56:42 PDT
http://trac.webkit.org/changeset/90662 broke the build:
Chromium gtests exposed a bug where we return the end value for selectionStart (Requested by ojan on #webkit).

This is an automatic bug report generated by the sheriff-bot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests case pain.

"Only you can prevent forest fires." -- Smokey the Bear
Comment 1 WebKit Commit Bot 2011-07-08 15:56:50 PDT
Created attachment 100174 [details]
ROLLOUT of r90662

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the rollout will be successful.  This process takes approximately 15 minutes.

If you would like to land the rollout faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID --ignore-builders

where ATTACHMENT_ID is the ID of this attachment.
Comment 2 Ojan Vafai 2011-07-08 15:57:49 PDT
Comment on attachment 100174 [details]
ROLLOUT of r90662

Confirmed with rniwa on #chromium that he'd like to rollback.
Comment 3 WebKit Review Bot 2011-07-08 15:59:08 PDT
Comment on attachment 100174 [details]
ROLLOUT of r90662

Rejecting attachment 100174 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=ec2-cq-01', '--port..." exit_code: 2

Last 500 characters of output:
ed at 111 with fuzz 2 (offset 5 lines).
3 out of 4 hunks FAILED -- saving rejects to file Source/WebCore/rendering/RenderTextControl.h.rej
patching file Source/WebKit/qt/Api/qwebpage.cpp
Hunk #1 FAILED at 1111.
Hunk #2 FAILED at 1134.
2 out of 2 hunks FAILED -- saving rejects to file Source/WebKit/qt/Api/qwebpage.cpp.rej
patching file Source/WebKit/qt/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force']" exit_code: 1

Full output: http://queues.webkit.org/results/8995896