Bug 64211 - Rebaseline following r90646
Summary: Rebaseline following r90646
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Reveman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-08 15:54 PDT by David Reveman
Modified: 2011-07-13 07:05 PDT (History)
0 users

See Also:

Attachments
Rebaseline following r90646 (deleted)
2011-07-08 16:04 PDT, David Reveman 		no flags Details | Formatted Diff | Diff
Update pixel expectations for r90646 (deleted)
2011-07-11 11:30 PDT, David Reveman 		jamesr: review-
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Reveman 2011-07-08 15:54:49 PDT 
Rebaseline following r90646
Comment 1 David Reveman 2011-07-08 16:04:05 PDT 
Created attachment 100178 [details]
Rebaseline following r90646

Attempt to rebaseline chromium GPU tests following layer anti-aliasing changes.
Comment 2 David Reveman 2011-07-08 16:17:01 PDT 
This first attempt only includes tests that have previously expected results. The rebaseline script failed to find previous results for most tests on Windows. Is this expected?
Comment 3 David Reveman 2011-07-11 11:30:36 PDT 
Created attachment 100335 [details]
Update pixel expectations for r90646
Comment 4 James Robinson 2011-07-11 13:01:48 PDT 
Comment on attachment 100335 [details]
Update pixel expectations for r90646

This patch is mangled, see LayoutTests/platform/chromium-gpu-linux/compositing/reflections/reflection-positioning-expected.png.  Additionally our tools don't really support 6mb+ patches.  It'll probably be easier for me to just rebaseline
Comment 5 David Reveman 2011-07-11 13:33:51 PDT 
(In reply to comment #4)
> (From update of attachment 100335 [details])
> This patch is mangled, see LayoutTests/platform/chromium-gpu-linux/compositing/reflections/reflection-positioning-expected.png.  Additionally our tools don't really support 6mb+ patches.  It'll probably be easier for me to just rebaseline

It was generated with git-format-patch. Guess the tools doesn't support that. Is there a way to generate proper webkit patches with binary file changes from a git checkout?

Let me know if you want me to do a svn checkout and generate a patch for the same change with svn-create-patch.