With NRWT, many plugin-related tests fail

[Simon Fraser (smfr)]

I see lots of plugin-related tests failing with NRWT, in a Mac debug build on SnowLeopard. TestNetscapePlugIn.plugin exists in my WebKitBuild/Debug dir. I'm running with the --debug flag.

[Simon Fraser (smfr)]

Created attachment 100165 [details]
Webarchive of results

Attached results from a debug build at r90640.

[Adam Barth]

Thanks Simon.

[Simon Fraser (smfr)]

DRT has addTestPluginsToPluginSearchPath().

[Eric Seidel (no email)]

Thanks!  I'll take a look this weekend.

[Eric Seidel (no email)]

Hm...

% new-run-webkit-tests plugins
All 105 tests ran as expected.

All plugin tests pass for me on my machine.

I can't see the diffs from your run.  BUt if you zip up your /tmp/layout-test-results directory after a run, I'm happy to take a look.

[Eric Seidel (no email)]

static void addTestPluginsToPluginSearchPath(const char* executablePath)
{
    NSString *pwd = [[NSString stringWithUTF8String:executablePath] stringByDeletingLastPathComponent];
    [WebPluginDatabase setAdditionalWebPlugInPaths:[NSArray arrayWithObject:pwd]];
    [[WebPluginDatabase sharedDatabase] refresh];
}

Is the function you referenced before.  It adds the build directory of DRT to the plugin search path.  Which looks correct.

Are you running new-run-webkit-tests directly (or is run-webkit-tests calling it for you?)

I assume you're running the tests with WebKit1?  (Right now run-webkit-tests will call old-run-webkit-tests if you run it for WebKit2, since NRWT's WebKit2 support isn't quite done yet.  See bug 56729.)

[Eric Seidel (no email)]

I tried deleting TestNetscapePlugin.plugin from my build directory, and NRWT correctly re-built it (I suspect it might not know how to, but it did!)

[Eric Seidel (no email)]

I tried executing new-run-webkit-tests --debug plugins (explicitly adding the --debug flag in case that might confuse things) but that didn't repro the failures either. :(

[Eric Seidel (no email)]

I'm testing on:
ProductName:	Mac OS X
ProductVersion:	10.6.8
BuildVersion:	10K540

[Eric Seidel (no email)]

For completeness, I should mention I was testing with r90548.

[Simon Fraser (smfr)]

I'll investigate.

[Simon Fraser (smfr)]

I had a broken symlink in ~/Library/Internet Plugins