RESOLVED FIXED 64203
Lists of flaky revisions on TestFailures page can get so long they're hard to navigate 
https://bugs.webkit.org/show_bug.cgi?id=64203
Summary Lists of flaky revisions on TestFailures page can get so long they're hard to...
Adam Roben (:aroben)
Reported 2011-07-08 14:24:57 PDT
Lists of flaky revisions on TestFailures page can get so long they're hard to navigate
Attachments
Patch (5.28 KB, patch)
2011-07-08 14:25 PDT, Adam Roben (:aroben) 		dbates: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Roben (:aroben)
Comment 1 2011-07-08 14:25:52 PDT
Created attachment 100163 [details] Patch
Daniel Bates
Comment 2 2011-07-08 15:44:25 PDT
Comment on attachment 100163 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=100163&action=review > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:513 > + item.appendChild(document.createTextNode('\u22ee')); Nit: I would suggest either defining a const VerticalEllipsis = '\u22ee' or putting an inline comment here, like // Vertical ellipsis.
Daniel Bates
Comment 3 2011-07-08 15:49:14 PDT
Comment on attachment 100163 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=100163&action=review > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector.js:93 > + const startAndEndAbbreviatedExamplesCount = 3; The code also assumes that this is constant is always >= 1. Maybe we should have a comment to state this.
Daniel Bates
Comment 4 2011-07-08 15:50:39 PDT
(In reply to comment #3) > > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector.js:93 > > + const startAndEndAbbreviatedExamplesCount = 3; > > The code also assumes that this is constant is always >= 1. Maybe we should have a comment to state this. I mean't to write that the constant must always be > 1.
Adam Roben (:aroben)
Comment 5 2011-07-09 12:04:18 PDT
Comment on attachment 100163 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=100163&action=review >> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector.js:93 >> + const startAndEndAbbreviatedExamplesCount = 3; > > The code also assumes that this is constant is always >= 1. Maybe we should have a comment to state this. Added a console.assert. >> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:513 >> + item.appendChild(document.createTextNode('\u22ee')); > > Nit: I would suggest either defining a const VerticalEllipsis = '\u22ee' or putting an inline comment here, like // Vertical ellipsis. Done.
Adam Roben (:aroben)
Comment 6 2011-07-09 12:06:08 PDT
Committed r90682: <http://trac.webkit.org/changeset/90682>
Note You need to log in before you can comment on or make changes to this bug.