Bug 64199 - TestResultsServer should keep old test results
Summary: TestResultsServer should keep old test results
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks: 64189
  Show dependency treegraph
 
Reported: 2011-07-08 13:38 PDT by Adam Barth
Modified: 2011-07-08 14:18 PDT (History)
2 users (show)

See Also:


Attachments
Patch (6.19 KB, patch)
2011-07-08 13:42 PDT, Adam Barth
no flags Details | Formatted Diff | Diff
Patch (6.96 KB, patch)
2011-07-08 14:05 PDT, Adam Barth
ojan: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2011-07-08 13:38:43 PDT
TestResultsServer should keep old test results
Comment 1 Adam Barth 2011-07-08 13:42:24 PDT
Created attachment 100155 [details]
Patch
Comment 2 Ojan Vafai 2011-07-08 13:59:27 PDT
Comment on attachment 100155 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=100155&action=review

> Tools/ChangeLog:8
> +        Having historical data will help use do failure archeology.

s/use/us

> Tools/TestResultServer/handlers/testfilehandler.py:107
> +        if callback_name:

If callback_name is optional, it should default to None above, right?

> Tools/TestResultServer/handlers/testfilehandler.py:133
> +        file = db.get(key)

Not entirely sure what this does. What are valid values for "key"?

> Tools/TestResultServer/templates/showfilelist.jsonp:4
> +{% for file in files %}
> +  "{{ file.key }}",
> +{% endfor %}

Do we want to use a richer format for this? For example, do we want to include the metadata we have about each file? Basically the data we currently show at http://test-results.appspot.com/testfile.
Comment 3 Adam Barth 2011-07-08 14:01:37 PDT
> > Tools/TestResultServer/handlers/testfilehandler.py:133
> > +        file = db.get(key)
> 
> Not entirely sure what this does. What are valid values for "key"?

AppEngine datastore keys.

> > Tools/TestResultServer/templates/showfilelist.jsonp:4
> > +{% for file in files %}
> > +  "{{ file.key }}",
> > +{% endfor %}
> 
> Do we want to use a richer format for this? For example, do we want to include the metadata we have about each file? Basically the data we currently show at http://test-results.appspot.com/testfile.

I'll add some more structure here so that it is future-proof.
Comment 4 Adam Barth 2011-07-08 14:05:45 PDT
Created attachment 100159 [details]
Patch
Comment 5 Adam Barth 2011-07-08 14:18:19 PDT
Committed r90665: <http://trac.webkit.org/changeset/90665>