WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
64199
TestResultsServer should keep old test results
https://bugs.webkit.org/show_bug.cgi?id=64199
Summary
TestResultsServer should keep old test results
Adam Barth
Reported
2011-07-08 13:38:43 PDT
TestResultsServer should keep old test results
Attachments
Patch
(6.19 KB, patch)
2011-07-08 13:42 PDT
,
Adam Barth
no flags
Details
Formatted Diff
Diff
Patch
(6.96 KB, patch)
2011-07-08 14:05 PDT
,
Adam Barth
ojan
: review+
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Adam Barth
Comment 1
2011-07-08 13:42:24 PDT
Created
attachment 100155
[details]
Patch
Ojan Vafai
Comment 2
2011-07-08 13:59:27 PDT
Comment on
attachment 100155
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=100155&action=review
> Tools/ChangeLog:8 > + Having historical data will help use do failure archeology.
s/use/us
> Tools/TestResultServer/handlers/testfilehandler.py:107 > + if callback_name:
If callback_name is optional, it should default to None above, right?
> Tools/TestResultServer/handlers/testfilehandler.py:133 > + file = db.get(key)
Not entirely sure what this does. What are valid values for "key"?
> Tools/TestResultServer/templates/showfilelist.jsonp:4 > +{% for file in files %} > + "{{ file.key }}", > +{% endfor %}
Do we want to use a richer format for this? For example, do we want to include the metadata we have about each file? Basically the data we currently show at
http://test-results.appspot.com/testfile
.
Adam Barth
Comment 3
2011-07-08 14:01:37 PDT
> > Tools/TestResultServer/handlers/testfilehandler.py:133 > > + file = db.get(key) > > Not entirely sure what this does. What are valid values for "key"?
AppEngine datastore keys.
> > Tools/TestResultServer/templates/showfilelist.jsonp:4 > > +{% for file in files %} > > + "{{ file.key }}", > > +{% endfor %} > > Do we want to use a richer format for this? For example, do we want to include the metadata we have about each file? Basically the data we currently show at
http://test-results.appspot.com/testfile
.
I'll add some more structure here so that it is future-proof.
Adam Barth
Comment 4
2011-07-08 14:05:45 PDT
Created
attachment 100159
[details]
Patch
Adam Barth
Comment 5
2011-07-08 14:18:19 PDT
Committed
r90665
: <
http://trac.webkit.org/changeset/90665
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug