Bug 64197 - checkout_unittest contains ugly, fragile code to find the Scripts directory
Summary: checkout_unittest contains ugly, fragile code to find the Scripts directory
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Roben (:aroben)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-08 12:50 PDT by Adam Roben (:aroben)
Modified: 2011-07-08 13:02 PDT (History)
2 users (show)

See Also:

Attachments
Patch (2.74 KB, patch)
2011-07-08 12:50 PDT, Adam Roben (:aroben) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Roben (:aroben) 2011-07-08 12:50:08 PDT 
checkout_unittest contains ugly, fragile code to find the Scripts directory
Comment 1 Adam Roben (:aroben) 2011-07-08 12:50:45 PDT 
Created attachment 100148 [details]
Patch
Comment 2 Adam Barth 2011-07-08 12:52:48 PDT 
Comment on attachment 100148 [details]
Patch

We're generally careful about leaking real objects through mocks, but this looks pretty safe.  Thanks.
Comment 3 WebKit Review Bot 2011-07-08 13:02:39 PDT 
Comment on attachment 100148 [details]
Patch

Clearing flags on attachment: 100148

Committed r90659: <http://trac.webkit.org/changeset/90659>
Comment 4 WebKit Review Bot 2011-07-08 13:02:43 PDT 
All reviewed patches have been landed.  Closing bug.