REGRESSION (r90564): test-webkitpy failing on multiple bots due to commit-log-editor errors
Created attachment 100135 [details] Patch
Comment on attachment 100135 [details] Patch Ok. Do I need to make sure this env variable is set on the commit bots?
(In reply to comment #2) > (From update of attachment 100135 [details]) > Ok. Do I need to make sure this env variable is set on the commit bots? No. You already ensured the git variable user.name is set, which is used as a fallback.
Comment on attachment 100135 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=100135&action=review > Tools/Scripts/webkitpy/common/checkout/checkout_unittest.py:129 > + kwargs['env'] = env You can just pass it as env=env and it will automagically end up on the other side as part of kwargs. **kwargs is expanding the "kwargs" dictionary (not a special name) to be named args.
** can be used to either stuff all the named args into a dictionary (of any name of your choosing, although conventionally kwargs) or to expand a dictionary into named args when calling a function. so defining a function as: def foo(*blah, **moreblah) will take all the non-named args, and put them into a tuple() blah, and all the named args and put them into a dict() moreblah Calling *listname will expand an arglist into a list of args, but only during a function call it seems. I thought * was a generic "expand tuple" operator, but I've since learned this morning it's just part of the language grammar. :) http://docs.python.org/reference/expressions.html#calls
Comment on attachment 100135 [details] Patch Clearing flags on attachment: 100135 Committed r90648: <http://trac.webkit.org/changeset/90648>
All reviewed patches have been landed. Closing bug.
Comment on attachment 100135 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=100135&action=review >> Tools/Scripts/webkitpy/common/checkout/checkout_unittest.py:129 >> + kwargs['env'] = env > > You can just pass it as env=env and it will automagically end up on the other side as part of kwargs. **kwargs is expanding the "kwargs" dictionary (not a special name) to be named args. If kwargs happens to already contain a value for 'env' then passing env=env will cause a runtime error.