Bug 64174 - [Qt][WK2] Views should expose QActions for basic navigation.
Summary: [Qt][WK2] Views should expose QActions for basic navigation.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords: Qt, QtTriaged
Depends on:
Blocks:
 
Reported: 2011-07-08 10:14 PDT by Andreas Kling
Modified: 2011-07-08 11:38 PDT (History)
2 users (show)

See Also:


Attachments
Proposed patch (10.43 KB, patch)
2011-07-08 10:17 PDT, Andreas Kling
benjamin: review-
Details | Formatted Diff | Diff
Proposed patch v2 (15.93 KB, patch)
2011-07-08 11:08 PDT, Andreas Kling
benjamin: review+
kling: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2011-07-08 10:14:12 PDT
The web views should expose QActions for Back, Forward, Reload and Stop.
Comment 1 Andreas Kling 2011-07-08 10:17:00 PDT
Created attachment 100130 [details]
Proposed patch
Comment 2 Benjamin Poulain 2011-07-08 10:18:27 PDT
Comment on attachment 100130 [details]
Proposed patch

Needs tests :)
Comment 3 Andreas Kling 2011-07-08 10:25:30 PDT
(In reply to comment #2)
> (From update of attachment 100130 [details])
> Needs tests :)

Ah duh, in the CommonViewInterface of course.
I also realized that for the mobile view, the page should have the navigation actions, not the view.
Cookin' a new one for ya.
Comment 4 Andreas Kling 2011-07-08 11:08:14 PDT
Created attachment 100136 [details]
Proposed patch v2
Comment 5 Andreas Kling 2011-07-08 11:11:18 PDT
Comment on attachment 100136 [details]
Proposed patch v2

View in context: https://bugs.webkit.org/attachment.cgi?id=100136&action=review

> Tools/MiniBrowser/qt/BrowserView.cpp:97
> +        return touchWebView()->navigationAction(which);

Should be touchWebView()->page()->..., will fix when landing.
Comment 6 WebKit Review Bot 2011-07-08 11:12:03 PDT
Attachment 100136 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1

Source/WebKit2/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Source/WebKit2/UIProcess/API/qt/tests/commonviewtests/webviewabstraction.cpp:20:  Found other header before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Total errors found: 2 in 18 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 7 Early Warning System Bot 2011-07-08 11:25:43 PDT
Comment on attachment 100136 [details]
Proposed patch v2

Attachment 100136 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/9000616
Comment 8 Benjamin Poulain 2011-07-08 11:29:11 PDT
Comment on attachment 100136 [details]
Proposed patch v2

Stylebot + 

> Tools/MiniBrowser/qt/BrowserView.cpp:98
> +    Q_ASSERT(0);

Q_ASSERT(false)
Comment 9 Andreas Kling 2011-07-08 11:38:04 PDT
Committed r90647: <http://trac.webkit.org/changeset/90647>