RESOLVED INVALID 64172
[Qt] Avoid using setSelectionRange in ::inputMethodEvent as it does not work for contentEditable 
https://bugs.webkit.org/show_bug.cgi?id=64172
Summary [Qt] Avoid using setSelectionRange in ::inputMethodEvent as it does not work ...
Kenneth Rohde Christiansen
Reported 2011-07-08 08:52:54 PDT
SSIA
Attachments
Patch (3.66 KB, patch)
2011-07-08 08:55 PDT, Kenneth Rohde Christiansen 		hausmann: review+
hausmann: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kenneth Rohde Christiansen
Comment 1 2011-07-08 08:55:49 PDT
Created attachment 100123 [details] Patch
Kenneth Rohde Christiansen
Comment 2 2011-07-08 08:58:13 PDT
Kling/Laszlo, do you know who might be able to test this? I guess they are using it for Symbian.
Enrica Casucci
Comment 3 2011-10-07 10:29:49 PDT
Comment on attachment 100123 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=100123&action=review The patch looks fine, but I'd like to see the variable name changed. > Source/WebKit/qt/Api/qwebpage.cpp:1084 > + Element* node = 0; Please rename the variable and its references below.
Simon Hausmann
Comment 4 2012-03-07 11:53:41 PST
Comment on attachment 100123 [details] Patch r=me, but I agree with Enrica. Although that could also be done in a separate patch if you want. Please also make sure that the existing input method tests still pass :)
Michael Brüning
Comment 5 2013-01-04 03:08:38 PST
Checking this because it was on the reminder list - it seems that this patch is obsolete / was rewritten and landed already. Kenneth, Simon, do you agree?
Jocelyn Turcotte
Comment 6 2014-02-03 03:18:10 PST
=== Bulk closing of Qt bugs === If you believe that this bug report is still relevant for a non-Qt port of webkit.org, please re-open it and remove [Qt] from the summary. If you believe that this is still an important QtWebKit bug, please fill a new report at https://bugreports.qt-project.org and add a link to this issue. See http://qt-project.org/wiki/ReportingBugsInQt for additional guidelines.
Note You need to log in before you can comment on or make changes to this bug.