Bug 64162 - [skia] don't rely on lockPixels failure to detect gpu-backed device (in prep for skia roll)
Summary: [skia] don't rely on lockPixels failure to detect gpu-backed device (in prep ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mike Reed
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-08 05:39 PDT by Mike Reed
Modified: 2011-07-08 11:14 PDT (History)
4 users (show)

See Also:


Attachments
Patch (1.50 KB, patch)
2011-07-08 05:40 PDT, Mike Reed
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Reed 2011-07-08 05:39:19 PDT
[skia] don't rely on lockPixels failure to detect gpu-backed device (in prep for skia roll)
Comment 1 Mike Reed 2011-07-08 05:40:37 PDT
Created attachment 100109 [details]
Patch
Comment 2 Brian Salomon 2011-07-08 05:44:56 PDT
(Unofficial) LGTM.
Comment 3 Stephen White 2011-07-08 10:16:52 PDT
Comment on attachment 100109 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=100109&action=review

> Source/WebCore/platform/graphics/skia/ImageBufferSkia.cpp:304
> +    bool temporaryBitmap = !!deviceBitmap.getTexture();

Will this code work with the current rev of skia?  If not, you'll have to wrap it temporarily in an #ifdef that you turn on in Chrome (ie., two-sided change), then remove it after the skia roll.
Comment 4 Mike Reed 2011-07-08 10:36:57 PDT
this does work with the current rev. of skia. It is being done so that we can perform a new rev. later on.
Comment 5 Stephen White 2011-07-08 10:44:06 PDT
Ok, great.  r=me
Comment 6 WebKit Review Bot 2011-07-08 11:13:59 PDT
Comment on attachment 100109 [details]
Patch

Clearing flags on attachment: 100109

Committed r90645: <http://trac.webkit.org/changeset/90645>
Comment 7 WebKit Review Bot 2011-07-08 11:14:03 PDT
All reviewed patches have been landed.  Closing bug.