Parts of the webkit-file tool that are common to all platforms should be factored out into separate base classes, in order to remove code duplication and force uniform conventions.
Created attachment 100077 [details] work-in-progress Initial draft
Comment on attachment 100077 [details] work-in-progress View in context: https://bugs.webkit.org/attachment.cgi?id=100077&action=review > Tools/Scripts/webkitpy/common/project/base.py:184 > + -) a function 'write_project_file(self, project, file_path)' that writes the project into the passed-in file A common pattern in Python is to define the function in this class an throw a NotImplemented exception. If you search webkitpy, you'll see a bunch of examples of this pattern.
Is this work still active?
Yes, just recently returned to it - uploading a shiny new work-in-progress patch shortly
Created attachment 132040 [details] work-in-progress Expanded and completely refactored work-in-progress.
Created attachment 134528 [details] Non-project-specific base classes for the webkit-file tool. Everything else depends on them.
The patch might be a bit too big for me to review... isn't it possible to break it down? (But if anyone could review the patch at a breath, that would be best:-)
Comment on attachment 134528 [details] Non-project-specific base classes for the webkit-file tool. Everything else depends on them. Nobody is working on this and it's cluttering up the Bugzilla review queue so I'm going to go ahead and close this.