RESOLVED LATER 64148
webkit-file utility needs common interface for all platforms 
https://bugs.webkit.org/show_bug.cgi?id=64148
Summary webkit-file utility needs common interface for all platforms
Roland Steiner
Reported 2011-07-07 22:28:25 PDT
Parts of the webkit-file tool that are common to all platforms should be factored out into separate base classes, in order to remove code duplication and force uniform conventions.
Attachments
work-in-progress (9.93 KB, patch)
2011-07-07 22:57 PDT, Roland Steiner 		no flags
DetailsFormatted DiffDiff
work-in-progress (52.83 KB, patch)
2012-03-15 07:17 PDT, Roland Steiner 		no flags
DetailsFormatted DiffDiff
Non-project-specific base classes for the webkit-file tool. Everything else depends on them. (48.56 KB, patch)
2012-03-29 01:46 PDT, Roland Steiner 		andersca: review-
andersca: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Roland Steiner
Comment 1 2011-07-07 22:57:39 PDT
Created attachment 100077 [details] work-in-progress Initial draft
Adam Barth
Comment 2 2011-07-07 23:50:05 PDT
Comment on attachment 100077 [details] work-in-progress View in context: https://bugs.webkit.org/attachment.cgi?id=100077&action=review > Tools/Scripts/webkitpy/common/project/base.py:184 > + -) a function 'write_project_file(self, project, file_path)' that writes the project into the passed-in file A common pattern in Python is to define the function in this class an throw a NotImplemented exception. If you search webkitpy, you'll see a bunch of examples of this pattern.
Eric Seidel (no email)
Comment 3 2012-01-05 15:37:57 PST
Is this work still active?
Roland Steiner
Comment 4 2012-03-15 07:02:52 PDT
Yes, just recently returned to it - uploading a shiny new work-in-progress patch shortly
Roland Steiner
Comment 5 2012-03-15 07:17:57 PDT
Created attachment 132040 [details] work-in-progress Expanded and completely refactored work-in-progress.
Roland Steiner
Comment 6 2012-03-29 01:46:05 PDT
Created attachment 134528 [details] Non-project-specific base classes for the webkit-file tool. Everything else depends on them.
Kentaro Hara
Comment 7 2012-03-29 17:09:41 PDT
The patch might be a bit too big for me to review... isn't it possible to break it down? (But if anyone could review the patch at a breath, that would be best:-)
Anders Carlsson
Comment 8 2013-10-31 08:30:06 PDT
Comment on attachment 134528 [details] Non-project-specific base classes for the webkit-file tool. Everything else depends on them. Nobody is working on this and it's cluttering up the Bugzilla review queue so I'm going to go ahead and close this.
Note You need to log in before you can comment on or make changes to this bug.