Refactoring luminance code in RenderSVGResourceMasker.
Created attachment 100070 [details]
Comment on attachment 100070 [details]
View in context: https://bugs.webkit.org/attachment.cgi?id=100070&action=review
Hm, do you actually plan to implement a non-generic code path at some point? Did anyone ask for that? I'm confused why this is needed, though I see the intention.
> +void ImageBuffer::toLuminanceMask()
You have to inline this as well - otherwhise there's no benefit in inlining genericToLumiMask() - correct me if I'm wrong.
> + maskerData->maskImage->toLuminanceMask();
That sounds fairly generic, how about convertToLuminanceMask() ?
Created attachment 100127 [details]
Created attachment 100152 [details]
Comment on attachment 100152 [details]
Attachment 100152 [details] did not pass mac-ews (mac):
Committed r90676: <http://trac.webkit.org/changeset/90676>