Bug 64146 - Refactoring luminance code in RenderSVGResourceMasker
Summary: Refactoring luminance code in RenderSVGResourceMasker
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dirk Schulze
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-07-07 22:09 PDT by Dirk Schulze
Modified: 2011-07-08 23:05 PDT (History)
1 user (show)

See Also:


Attachments
Patch (9.74 KB, patch)
2011-07-07 22:19 PDT, Dirk Schulze
no flags Details | Formatted Diff | Diff
Patch (9.80 KB, patch)
2011-07-08 09:54 PDT, Dirk Schulze
no flags Details | Formatted Diff | Diff
Patch (8.30 KB, patch)
2011-07-08 13:28 PDT, Dirk Schulze
simon.fraser: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Schulze 2011-07-07 22:09:35 PDT
Refactoring luminance code in RenderSVGResourceMasker.
Comment 1 Dirk Schulze 2011-07-07 22:19:39 PDT
Created attachment 100070 [details]
Patch
Comment 2 Nikolas Zimmermann 2011-07-08 08:18:05 PDT
Comment on attachment 100070 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=100070&action=review

Hm, do you actually plan to implement a non-generic code path at some point? Did anyone ask for that? I'm confused why this is needed, though I see the intention.

> Source/WebCore/platform/graphics/ImageBuffer.cpp:91
> +void ImageBuffer::toLuminanceMask()

You have to inline this as well - otherwhise there's no benefit in inlining genericToLumiMask() - correct me if I'm wrong.

> Source/WebCore/rendering/svg/RenderSVGResourceMasker.cpp:162
> +    maskerData->maskImage->toLuminanceMask();

That sounds fairly generic, how about convertToLuminanceMask() ?
Comment 3 Dirk Schulze 2011-07-08 09:54:36 PDT
Created attachment 100127 [details]
Patch
Comment 4 Dirk Schulze 2011-07-08 13:28:32 PDT
Created attachment 100152 [details]
Patch
Comment 5 WebKit Review Bot 2011-07-08 13:48:57 PDT
Comment on attachment 100152 [details]
Patch

Attachment 100152 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/9005003
Comment 6 Dirk Schulze 2011-07-08 23:05:45 PDT
Committed r90676: <http://trac.webkit.org/changeset/90676>