Bug 64145 - WebSocket: Clear cookies after test in httponly-cookie.pl
: WebSocket: Clear cookies after test in httponly-cookie.pl
Status: RESOLVED FIXED
: WebKit
Tools / Tests
: 528+ (Nightly build)
: All All
: P2 Normal
Assigned To:
:
:
:
: 50099
  Show dependency treegraph
 
Reported: 2011-07-07 21:15 PST by
Modified: 2011-07-07 23:41 PST (History)


Attachments
Patch (2.24 KB, patch)
2011-07-07 21:23 PST, Yuta Kitamura
no flags Review Patch | Details | Formatted Diff | Diff
Patch v2 (2.55 KB, patch)
2011-07-07 22:11 PST, Yuta Kitamura
no flags Review Patch | Details | Formatted Diff | Diff
Patch v3 (2.48 KB, patch)
2011-07-07 22:24 PST, Yuta Kitamura
no flags Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2011-07-07 21:15:20 PST
While I was testing the new protocol implementation, I found that a WebSocket test httponly-cookie.pl leaks cookies, which will cause a test failure after a new set of tests is added under http/tests/websocket/tests.
------- Comment #1 From 2011-07-07 21:23:50 PST -------
Created an attachment (id=100068) [details]
Patch
------- Comment #2 From 2011-07-07 21:29:54 PST -------
(From update of attachment 100068 [details])
View in context: https://bugs.webkit.org/attachment.cgi?id=100068&action=review

> LayoutTests/ChangeLog:11
> +        WebSocket: Clear cookies after test in httponly-cookie.pl
> +        https://bugs.webkit.org/show_bug.cgi?id=64145
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        * http/tests/websocket/tests/hixie76/httponly-cookie.pl:
> +        After the test, send an XHR request to itself with a query parameter,
> +        which erases cookies used in this test.
> +

Please mention the reason we need to clear cookies.
------- Comment #3 From 2011-07-07 22:11:52 PST -------
Created an attachment (id=100069) [details]
Patch v2
------- Comment #4 From 2011-07-07 22:13:07 PST -------
(From update of attachment 100068 [details])
View in context: https://bugs.webkit.org/attachment.cgi?id=100068&action=review

>> LayoutTests/ChangeLog:11
>> +
> 
> Please mention the reason we need to clear cookies.

Fixed in patch v2.
------- Comment #5 From 2011-07-07 22:20:38 PST -------
(From update of attachment 100069 [details])
View in context: https://bugs.webkit.org/attachment.cgi?id=100069&action=review

> LayoutTests/ChangeLog:12
> +        While I was testing the new protocol implementation, I found that
> +        this test leaks cookies, which would cause a test failure if we put
> +        a copy of this test under http/tests/websocket/tests.
> +
> +        To avoid this issue, cookies should be removed before the test ends.

Using the word "I" in ChangeLog looks strange. We need objective facts, instead of your experience or viewpoint.
So I would like remove "While I was ..., I found that"
------- Comment #6 From 2011-07-07 22:24:16 PST -------
Created an attachment (id=100073) [details]
Patch v3
------- Comment #7 From 2011-07-07 22:25:27 PST -------
(From update of attachment 100073 [details])
ok
------- Comment #8 From 2011-07-07 23:41:40 PST -------
(From update of attachment 100073 [details])
Clearing flags on attachment: 100073

Committed r90612: <http://trac.webkit.org/changeset/90612>
------- Comment #9 From 2011-07-07 23:41:45 PST -------
All reviewed patches have been landed.  Closing bug.