Bug 64145 – WebSocket: Clear cookies after test in httponly-cookie.pl

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Yuta Kitamura]

While I was testing the new protocol implementation, I found that a WebSocket test httponly-cookie.pl leaks cookies, which will cause a test failure after a new set of tests is added under http/tests/websocket/tests.

[Yuta Kitamura]

Created attachment 100068 [details]
Patch

[Kent Tamura]

Comment on attachment 100068 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=100068&action=review

> LayoutTests/ChangeLog:11
> +        WebSocket: Clear cookies after test in httponly-cookie.pl
> +        https://bugs.webkit.org/show_bug.cgi?id=64145
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        * http/tests/websocket/tests/hixie76/httponly-cookie.pl:
> +        After the test, send an XHR request to itself with a query parameter,
> +        which erases cookies used in this test.
> +

Please mention the reason we need to clear cookies.

[Yuta Kitamura]

Created attachment 100069 [details]
Patch v2

[Yuta Kitamura]

Comment on attachment 100068 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=100068&action=review

>> LayoutTests/ChangeLog:11
>> +
> 
> Please mention the reason we need to clear cookies.

Fixed in patch v2.

[Kent Tamura]

Comment on attachment 100069 [details]
Patch v2

View in context: https://bugs.webkit.org/attachment.cgi?id=100069&action=review

> LayoutTests/ChangeLog:12
> +        While I was testing the new protocol implementation, I found that
> +        this test leaks cookies, which would cause a test failure if we put
> +        a copy of this test under http/tests/websocket/tests.
> +
> +        To avoid this issue, cookies should be removed before the test ends.

Using the word "I" in ChangeLog looks strange. We need objective facts, instead of your experience or viewpoint.
So I would like remove "While I was ..., I found that"

[Yuta Kitamura]

Created attachment 100073 [details]
Patch v3

[Kent Tamura]

Comment on attachment 100073 [details]
Patch v3

ok

[WebKit Review Bot]

Comment on attachment 100073 [details]
Patch v3

Clearing flags on attachment: 100073

Committed r90612: <http://trac.webkit.org/changeset/90612>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.