Bug 64145 - WebSocket: Clear cookies after test in httponly-cookie.pl
: WebSocket: Clear cookies after test in httponly-cookie.pl
Status: RESOLVED FIXED
Product: WebKit
Classification: Unclassified
Component: Tools / Tests
: 528+ (Nightly build)
: All All
: P2 Normal
Assigned To: Yuta Kitamura
:
Depends on:
Blocks: 50099
  Show dependency treegraph
 
Reported: 2011-07-07 21:15 PDT by Yuta Kitamura
Modified: 2011-07-07 23:41 PDT (History)
4 users (show)

See Also:


Attachments
Patch (2.24 KB, patch)
2011-07-07 21:23 PDT, Yuta Kitamura
no flags Details | Formatted Diff | Diff
Patch v2 (2.55 KB, patch)
2011-07-07 22:11 PDT, Yuta Kitamura
no flags Details | Formatted Diff | Diff
Patch v3 (2.48 KB, patch)
2011-07-07 22:24 PDT, Yuta Kitamura
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yuta Kitamura 2011-07-07 21:15:20 PDT
While I was testing the new protocol implementation, I found that a WebSocket test httponly-cookie.pl leaks cookies, which will cause a test failure after a new set of tests is added under http/tests/websocket/tests.
Comment 1 Yuta Kitamura 2011-07-07 21:23:50 PDT
Created attachment 100068 [details]
Patch
Comment 2 Kent Tamura 2011-07-07 21:29:54 PDT
Comment on attachment 100068 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=100068&action=review

> LayoutTests/ChangeLog:11
> +        WebSocket: Clear cookies after test in httponly-cookie.pl
> +        https://bugs.webkit.org/show_bug.cgi?id=64145
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        * http/tests/websocket/tests/hixie76/httponly-cookie.pl:
> +        After the test, send an XHR request to itself with a query parameter,
> +        which erases cookies used in this test.
> +

Please mention the reason we need to clear cookies.
Comment 3 Yuta Kitamura 2011-07-07 22:11:52 PDT
Created attachment 100069 [details]
Patch v2
Comment 4 Yuta Kitamura 2011-07-07 22:13:07 PDT
Comment on attachment 100068 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=100068&action=review

>> LayoutTests/ChangeLog:11
>> +
> 
> Please mention the reason we need to clear cookies.

Fixed in patch v2.
Comment 5 Kent Tamura 2011-07-07 22:20:38 PDT
Comment on attachment 100069 [details]
Patch v2

View in context: https://bugs.webkit.org/attachment.cgi?id=100069&action=review

> LayoutTests/ChangeLog:12
> +        While I was testing the new protocol implementation, I found that
> +        this test leaks cookies, which would cause a test failure if we put
> +        a copy of this test under http/tests/websocket/tests.
> +
> +        To avoid this issue, cookies should be removed before the test ends.

Using the word "I" in ChangeLog looks strange. We need objective facts, instead of your experience or viewpoint.
So I would like remove "While I was ..., I found that"
Comment 6 Yuta Kitamura 2011-07-07 22:24:16 PDT
Created attachment 100073 [details]
Patch v3
Comment 7 Kent Tamura 2011-07-07 22:25:27 PDT
Comment on attachment 100073 [details]
Patch v3

ok
Comment 8 WebKit Review Bot 2011-07-07 23:41:40 PDT
Comment on attachment 100073 [details]
Patch v3

Clearing flags on attachment: 100073

Committed r90612: <http://trac.webkit.org/changeset/90612>
Comment 9 WebKit Review Bot 2011-07-07 23:41:45 PDT
All reviewed patches have been landed.  Closing bug.