Bug 64138 – Clean up RenderWidget::destroy() to share more code

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Simon Fraser (smfr)]

RenderWidget::destroy() has comments about not sharing more code with other classes. This needs cleaning up. It's a PITA to add code here.

[Simon Fraser (smfr)]

Created attachment 100185 [details]
Patch

[James Robinson]

Comment on attachment 100185 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=100185&action=review

Looks great, just one question.

> Source/WebCore/rendering/RenderWidget.cpp:-142
> -    if (hasOverrideSize())
> -        setOverrideSize(-1);

this is different from what RenderBox::destroy() did, it did:
gOverrideSizeMap->remove(this)

are these equivalent?

[Simon Fraser (smfr)]

Almost:

void RenderBox::setOverrideSize(int s)
{
    if (s == -1) {
        if (hasOverrideSize()) {
            setHasOverrideSize(false);
            gOverrideSizeMap->remove(this);
        }

I'll change RenderBox::willBeDestroyed() to call setOverrideSize(-1);

[Simon Fraser (smfr)]

Created attachment 100189 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 100189 [details]
Patch

Transferring r+ from jamesr. New patch for the bots to chew on.

[Simon Fraser (smfr)]

http://trac.webkit.org/changeset/90675