WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
64138
Clean up RenderWidget::destroy() to share more code
https://bugs.webkit.org/show_bug.cgi?id=64138
Summary
Clean up RenderWidget::destroy() to share more code
Simon Fraser (smfr)
Reported
2011-07-07 17:42:13 PDT
RenderWidget::destroy() has comments about not sharing more code with other classes. This needs cleaning up. It's a PITA to add code here.
Attachments
Patch
(38.32 KB, patch)
2011-07-08 16:55 PDT
,
Simon Fraser (smfr)
no flags
Details
Formatted Diff
Diff
Patch
(38.28 KB, patch)
2011-07-08 17:24 PDT
,
Simon Fraser (smfr)
simon.fraser
: review+
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1
2011-07-08 16:55:37 PDT
Created
attachment 100185
[details]
Patch
James Robinson
Comment 2
2011-07-08 17:07:06 PDT
Comment on
attachment 100185
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=100185&action=review
Looks great, just one question.
> Source/WebCore/rendering/RenderWidget.cpp:-142 > - if (hasOverrideSize()) > - setOverrideSize(-1);
this is different from what RenderBox::destroy() did, it did: gOverrideSizeMap->remove(this) are these equivalent?
Simon Fraser (smfr)
Comment 3
2011-07-08 17:20:30 PDT
Almost: void RenderBox::setOverrideSize(int s) { if (s == -1) { if (hasOverrideSize()) { setHasOverrideSize(false); gOverrideSizeMap->remove(this); } I'll change RenderBox::willBeDestroyed() to call setOverrideSize(-1);
Simon Fraser (smfr)
Comment 4
2011-07-08 17:24:39 PDT
Created
attachment 100189
[details]
Patch
Simon Fraser (smfr)
Comment 5
2011-07-08 17:25:27 PDT
Comment on
attachment 100189
[details]
Patch Transferring r+ from jamesr. New patch for the bots to chew on.
Simon Fraser (smfr)
Comment 6
2011-07-08 17:43:31 PDT
http://trac.webkit.org/changeset/90675
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug