Bug 64119 – [chromium] Fix crash when compositing gets disabled mid-paint

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Adrienne Walker]

[chromium] Fix crash when compositing gets disabled mid-paint

[Adrienne Walker]

Created attachment 100018 [details]
Patch

[Adrienne Walker]

http://code.google.com/p/chromium/issues/detail?id=88682

[James Robinson]

Comment on attachment 100018 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=100018&action=review

> Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp:369
> +    if (!m_rootLayer)
> +        return;

do we think painting a sublayer is turning the compositor off?  we already have a null-check + early-out after updateRootLayerContents()

[Adrienne Walker]

(In reply to comment #3)
> (From update of attachment 100018 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=100018&action=review
> 
> > Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp:369
> > +    if (!m_rootLayer)
> > +        return;
> 
> do we think painting a sublayer is turning the compositor off?  we already have a null-check + early-out after updateRootLayerContents()

In this case, no.  However, there's no reason it couldn't.

I've fixed this bug at least three times now.  Can you forgive some extra checks for sanity's sake? :)

[James Robinson]

Comment on attachment 100018 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=100018&action=review

>>> Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp:369
>>> +        return;
>> 
>> do we think painting a sublayer is turning the compositor off?  we already have a null-check + early-out after updateRootLayerContents()
> 
> In this case, no.  However, there's no reason it couldn't.
> 
> I've fixed this bug at least three times now.  Can you forgive some extra checks for sanity's sake? :)

Yeah I know, but it's also really valuable to know which checks are working and which aren't.  We have some pretty defensive code in place to try to update compositing reqs for all layers before painting, so if that's failing then we should probably not bother since it's not free.  See http://trac.webkit.org/browser/trunk/Source/WebKit/chromium/src/WebViewImpl.cpp#L1146

Would you mind landing just the second check (in drawLayers()) without this, letting it go to canary, and seeing what that does?

[Adrienne Walker]

(In reply to comment #5)
> (From update of attachment 100018 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=100018&action=review

> Would you mind landing just the second check (in drawLayers()) without this, letting it go to canary, and seeing what that does?

Sure, will do.

[Adrienne Walker]

Created attachment 100026 [details]
Patch

[James Robinson]

Comment on attachment 100026 [details]
Patch

Lesse what happens

[Adrienne Walker]

Committed r90587: <http://trac.webkit.org/changeset/90587>