Bug 64093 - [Qt][WK2] Views should know about WebProcess crash/relaunch.
Summary: [Qt][WK2] Views should know about WebProcess crash/relaunch.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords: Qt, QtTriaged
Depends on:
Blocks:
 
Reported: 2011-07-07 08:46 PDT by Andreas Kling
Modified: 2011-07-07 10:28 PDT (History)
1 user (show)

See Also:


Attachments
Proposed patch (7.33 KB, patch)
2011-07-07 08:56 PDT, Andreas Kling
benjamin: review+
benjamin: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2011-07-07 08:46:43 PDT
The crash/relaunch callbacks should propagate through the ViewInterface.
Comment 1 Andreas Kling 2011-07-07 08:56:09 PDT
Created attachment 99988 [details]
Proposed patch
Comment 2 Benjamin Poulain 2011-07-07 09:44:45 PDT
Comment on attachment 99988 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=99988&action=review

> Source/WebKit2/UIProcess/API/qt/qdesktopwebview.cpp:229
> +    isCrashed = false;

Don't you need to update here?

> Source/WebKit2/UIProcess/qt/QtWebPageProxy.cpp:548
>      setDrawingAreaSize(m_viewInterface->drawingAreaSize());
> -
> -    m_isConnectedToEngine = true;
> +    m_viewInterface->didRelaunchProcess();

I would invert the order of those calls. :)
Comment 3 Andreas Kling 2011-07-07 10:28:37 PDT
Committed r90572: <http://trac.webkit.org/changeset/90572>